fix(storage): add methods to s4 non idempotent operations#56
Merged
cojenco merged 4 commits intogoogleapis:masterfrom Sep 7, 2021
Merged
fix(storage): add methods to s4 non idempotent operations#56cojenco merged 4 commits intogoogleapis:masterfrom
cojenco merged 4 commits intogoogleapis:masterfrom
Conversation
Contributor
cojenco
commented
Sep 2, 2021
- Add methods to Scenario 4 non idempotent operations
- For scenarios 3 and 4 that should not retry, revise instruction cases to a single forced error
tritone
approved these changes
Sep 4, 2021
| "cases": [ | ||
| { | ||
| "instructions": ["return-503", "return-503"] | ||
| "instructions": ["return-503"] |
Contributor
There was a problem hiding this comment.
I think it is good to have instruction sets with multiple failures. We should revisit this at some point, though, to add additional instruction sets that cover more errors.
Contributor
Author
There was a problem hiding this comment.
SGTM! Adding instruction sets with multiple failures to S3 and S4, we would need to make adjustments on verifying if all test instructions are used -- differentiate when test instructions should be fully consumed and when not.
BenWhitehead
approved these changes
Sep 7, 2021
BenWhitehead
added a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Sep 8, 2021
…4ce (#363) googleapis/conformance-tests@5c25424 chore: rename cloud-storage-dpes to cloud-storage-dpe ([#59](googleapis/conformance-tests#59)) googleapis/conformance-tests@32a2fd4 fix: update scenario 5 to only provide a single instruction for the expected failure ([#58](googleapis/conformance-tests#58)) googleapis/conformance-tests@0fe5931 fix(storage): add methods to s4 non idempotent operations ([#56](googleapis/conformance-tests#56)) googleapis/conformance-tests@64c08de fix(storage): add key resource to HMAC methods that require it ([#54](googleapis/conformance-tests#54)) googleapis/conformance-tests@17650a1 fix(storage): fix typo in method names ([#53](googleapis/conformance-tests#53)) Full diff: googleapis/conformance-tests@37ddc58...5c25424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.