Skip to content

Bundle caffeine in the with-dependencies JAR#1398

Closed
lgemeinhardt wants to merge 1 commit into
google:masterfrom
lgemeinhardt:shade-caffeine
Closed

Bundle caffeine in the with-dependencies JAR#1398
lgemeinhardt wants to merge 1 commit into
google:masterfrom
lgemeinhardt:shade-caffeine

Conversation

@lgemeinhardt

Copy link
Copy Markdown
Contributor

Add caffeine in with-dependencies JAR, broken after bfb1789
Similar to #1259 and #1238

@don-vip don-vip mentioned this pull request Feb 29, 2020
@lgemeinhardt lgemeinhardt changed the title Bundle Guava's caffeine in the with-dependencies JAR Bundle caffeine in the with-dependencies JAR Mar 16, 2020
@mernst

mernst commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

diffutils-1.3.0.jar is also needed, to support -XepPatchChecks.

@Preston4tw Preston4tw mentioned this pull request Apr 24, 2020
@cushon

cushon commented May 12, 2020

Copy link
Copy Markdown
Collaborator

Thanks for the fix, this PR is subsumed by #1587.

@cushon cushon closed this May 12, 2020
lgemeinhardt added a commit to lgemeinhardt/error-prone that referenced this pull request Oct 22, 2024
Add google-java-format in with-dependencies JAR, broken after google@5f71110
Similar to google#1398, google#1259 and google#1238
copybara-service Bot pushed a commit that referenced this pull request Oct 30, 2024
Add google-java-format in with-dependencies JAR, broken after 5f71110 Similar to #1398, #1259 and #1238

Fixes #4633

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4633 from lgemeinhardt:shade-google-java-format d468c7b
PiperOrigin-RevId: 691131237
copybara-service Bot pushed a commit that referenced this pull request Oct 30, 2024
Add google-java-format in with-dependencies JAR, broken after 5f71110 Similar to #1398, #1259 and #1238

Fixes #4633

COPYBARA_INTEGRATE_REVIEW=#4633 from lgemeinhardt:shade-google-java-format d468c7b
PiperOrigin-RevId: 691416915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants