CanBeStatic: Fix NPE#1111
Closed
don-vip wants to merge 1 commit into
Closed
Conversation
simon04
pushed a commit
to JOSM/josm
that referenced
this pull request
Sep 5, 2018
See google/error-prone#1111 See google/error-prone#1106 (comment) git-svn-id: https://josm.openstreetmap.de/svn/trunk@14226 0c6e7542-c601-0410-84e7-c038aed88b3b
Collaborator
|
Can you add a test? |
floscher
pushed a commit
to floscher/josm
that referenced
this pull request
Sep 6, 2018
See google/error-prone#1111 See google/error-prone#1106 (comment) git-svn-id: https://josm.openstreetmap.de/svn/trunk@14226 0c6e7542-c601-0410-84e7-c038aed88b3b
johsin18
pushed a commit
to johsin18/josm
that referenced
this pull request
Mar 1, 2020
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13): - google/error-prone#1107 - google/error-prone#1110 - google/error-prone#1111 - google/error-prone#1398 - google/error-prone#1439 git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
simon04
pushed a commit
to JOSM/josm
that referenced
this pull request
Mar 25, 2020
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13): - google/error-prone#1107 - google/error-prone#1110 - google/error-prone#1111 - google/error-prone#1398 - google/error-prone#1439 git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
Merged
kluever
pushed a commit
that referenced
this pull request
May 17, 2020
JDK 12 changes the representation of labelled breaks to use an identifier for the label (instead of just a name), and the identifier doesn't have a symbol. Fixes #1111 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311832221
kluever
pushed a commit
that referenced
this pull request
May 17, 2020
JDK 12 changes the representation of labelled breaks to use an identifier for the label (instead of just a name), and the identifier doesn't have a symbol. Fixes #1111 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311832221
floscher
pushed a commit
to floscher/josm
that referenced
this pull request
Oct 28, 2020
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13): - google/error-prone#1107 - google/error-prone#1110 - google/error-prone#1111 - google/error-prone#1398 - google/error-prone#1439 git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1106 (comment)
Solves NPE (after #1107 and #1110 are merged) with Java 12: