Skip to content

Finally: Replace .label by .getLabel()#1107

Closed
don-vip wants to merge 1 commit into
google:masterfrom
don-vip:jdk12
Closed

Finally: Replace .label by .getLabel()#1107
don-vip wants to merge 1 commit into
google:masterfrom
don-vip:jdk12

Conversation

@don-vip

@don-vip don-vip commented Sep 3, 2018

Copy link
Copy Markdown
Contributor

simon04 pushed a commit to JOSM/josm that referenced this pull request Sep 4, 2018
floscher pushed a commit to floscher/josm that referenced this pull request Sep 5, 2018
@don-vip don-vip mentioned this pull request Sep 5, 2018
@floscher

Copy link
Copy Markdown

I also encountered this exception in https://gitlab.com/JOSM/Mapillary/-/jobs/107783724

@don-vip

don-vip commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

@floscher you can use JOSM patched version of error_prone

@volmus

volmus commented Apr 3, 2019

Copy link
Copy Markdown

@cushon
Is this going to be merged anytime soon?

@bgalek

bgalek commented Apr 26, 2019

Copy link
Copy Markdown

@cushon - Looking forward for this change :)

@volmus

volmus commented Jun 4, 2019

Copy link
Copy Markdown

@cpovirk @ronshapiro

@gliptak

gliptak commented Mar 20, 2020

Copy link
Copy Markdown

@graememorgan please review

@bgalek bgalek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cushon cushon self-assigned this Mar 20, 2020
nick-someone pushed a commit that referenced this pull request Mar 23, 2020
See #1106 - field removed in JDK12 as per

Fixes #1107

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=302397069
@nick-someone nick-someone mentioned this pull request Mar 23, 2020
nick-someone pushed a commit that referenced this pull request Mar 23, 2020
See #1106 - field removed in JDK12 as per

Fixes #1107

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=302397069
@don-vip don-vip deleted the jdk12 branch June 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants