Skip to content

Bundle Guava's failureaccess in the with-dependencies JAR#1259

Closed
tbroyer wants to merge 1 commit into
google:masterfrom
tbroyer:shade-failureaccess
Closed

Bundle Guava's failureaccess in the with-dependencies JAR#1259
tbroyer wants to merge 1 commit into
google:masterfrom
tbroyer:shade-failureaccess

Conversation

@tbroyer

@tbroyer tbroyer commented Apr 14, 2019

Copy link
Copy Markdown
Contributor

Fixes #1238

@eaftan

eaftan commented Apr 15, 2019

Copy link
Copy Markdown
Contributor

@tbroyer could you PTAL at the CI failures?

@tbroyer

tbroyer commented Apr 15, 2019

Copy link
Copy Markdown
Contributor Author

AFAICT these are the same as on master, probably due to the update to Mockito 2.

ronshapiro pushed a commit that referenced this pull request Apr 18, 2019
Fixes #1259, fixes #1238

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=243966733
@ronshapiro ronshapiro mentioned this pull request Apr 18, 2019
@cushon cushon mentioned this pull request Apr 18, 2019
@cushon cushon closed this in 988857f Apr 18, 2019
lgemeinhardt added a commit to lgemeinhardt/error-prone that referenced this pull request Oct 22, 2024
Add google-java-format in with-dependencies JAR, broken after google@5f71110
Similar to google#1398, google#1259 and google#1238
copybara-service Bot pushed a commit that referenced this pull request Oct 30, 2024
Add google-java-format in with-dependencies JAR, broken after 5f71110 Similar to #1398, #1259 and #1238

Fixes #4633

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4633 from lgemeinhardt:shade-google-java-format d468c7b
PiperOrigin-RevId: 691131237
copybara-service Bot pushed a commit that referenced this pull request Oct 30, 2024
Add google-java-format in with-dependencies JAR, broken after 5f71110 Similar to #1398, #1259 and #1238

Fixes #4633

COPYBARA_INTEGRATE_REVIEW=#4633 from lgemeinhardt:shade-google-java-format d468c7b
PiperOrigin-RevId: 691416915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.NoClassDefFoundError: com/google/common/util/concurrent/internal/InternalFutureFailureAccess while using the "with-dependencies.jar"

3 participants