sources/saml: Fix signature verification order to accommodate encrypted assertions#19593
Merged
PeshekDotDev merged 2 commits intomainfrom Jan 20, 2026
Merged
sources/saml: Fix signature verification order to accommodate encrypted assertions#19593PeshekDotDev merged 2 commits intomainfrom
PeshekDotDev merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19593 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 949 949
Lines 52069 52068 -1
==========================================
+ Hits 48560 48565 +5
+ Misses 3509 3503 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-37ec60b69f70dd237a07140b8c6735356b62f887
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-37ec60b69f70dd237a07140b8c6735356b62f887Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
approved these changes
Jan 20, 2026
Member
BeryJu
left a comment
There was a problem hiding this comment.
LGTM, added some type hints where applicable
authentik-automation bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…ed assertions (#19593) * sources/saml: Fix signature verificaiton order on encrypted responses * type hints Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens Langhammer <jens@goauthentik.io>
Contributor
|
🍒 Cherry-pick to |
BeryJu
added a commit
that referenced
this pull request
Jan 20, 2026
…ed assertions (cherry-pick #19593 to version-2025.12) (#19614) sources/saml: Fix signature verification order to accommodate encrypted assertions (#19593) * sources/saml: Fix signature verificaiton order on encrypted responses * type hints --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Connor Peshek <connor@connorpeshek.me> Co-authored-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 20, 2026
* main: (191 commits) sources/saml: Fix signature verification order to accommodate encrypted assertions (#19593) providers/saml: fix structure of encrypted saml assertion (#19592) providers/saml: allow encryption certificates without private keys (#19526) integrations: add saml steps to mattermost (#19590) policies: fix Provider's authentication_flow not used when set (#19609) web: bump type-fest from 5.4.0 to 5.4.1 in /web (#19473) endpoints: fix endpoints stage marked as enterprise (#19607) core: bump selenium from 4.39.0 to 4.40.0 (#19564) core: bump goauthentik.io/api/v3 from 3.2026020.11 to 3.2026020.12 (#19594) core: bump openapitools/openapi-generator-cli from v7.18.0 to v7.19.0 in /scripts/api (#19595) core: bump fido2 from 2.1.0 to 2.1.1 (#19596) web: bump @sentry/browser from 10.34.0 to 10.35.0 in /web in the sentry group across 1 directory (#19597) core: bump aws-cdk-lib from 2.235.0 to 2.235.1 (#19598) web: bump the eslint group across 1 directory with 3 updates (#19599) web: bump the rollup group across 1 directory with 4 updates (#19600) web: bump the swc group across 1 directory with 12 updates (#19601) web: bump pino from 10.2.0 to 10.2.1 in /web (#19602) web: bump knip from 5.81.0 to 5.82.1 in /web (#19603) tests: improve e2e/integration test reliability (#19540) web: update @goauthentik/api (#19542) ...
6 tasks
BeryJu
pushed a commit
that referenced
this pull request
Jan 27, 2026
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 31, 2026
* main: (45 commits) sources/saml: Add testcases for PR #19593 (#19647) revert: website/integrations: wazuh: Change exchange key generation to 64 bytes (#19759) web: bump API Client version (#19760) core: bump djangoql from 0.18.2 to 0.19.1 (#19780) web: Vendor SFE Bootstrap (#19766) core, web: update translations (#19717) web: bump the eslint group across 1 directory with 3 updates (#19782) web: bump the react group across 1 directory with 2 updates (#19784) web: bump country-flag-icons from 1.6.8 to 1.6.9 in /web (#19785) providers/oauth2: Support login_hint (#19498) admin/files: add centralized theme variable support for file URLs (#19657) core: bump github.com/pires/go-proxyproto from 0.9.1 to 0.9.2 (#19778) core: bump openapitools/openapi-diff from 2.1.6 to 2.1.7 in /scripts/api (#19779) core: bump gssapi from 1.10.1 to 1.11.1 (#19781) ci: bump actions/attest-build-provenance from 3.1.0 to 3.2.0 (#19783) website/docs: endpoint devices: fix local device login (#19698) web: Enforce `challenge` nullish types. (#19768) web/elements: stabilize dual-select status height (#19734) web/a11y: CAPTCHA Stage Form (#19670) web/table: align row action icons and tooltip color (#19736) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Since decrypting saml changes its structure, verifying the signature of the response must happen before decryption
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)