web: Enforce challenge nullish types.#19768
Merged
GirlBossRush merged 2 commits intomainfrom Jan 27, 2026
Merged
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19768 +/- ##
==========================================
+ Coverage 92.99% 93.22% +0.23%
==========================================
Files 954 954
Lines 52443 52443
==========================================
+ Hits 48768 48891 +123
+ Misses 3675 3552 -123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-cc49cceccbc8f91383cbe7fecb68afbcda74773f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-cc49cceccbc8f91383cbe7fecb68afbcda74773fAfterwards, run the upgrade commands from the latest release notes. |
kensternberg-authentik
approved these changes
Jan 26, 2026
Contributor
kensternberg-authentik
left a comment
There was a problem hiding this comment.
Routine. I've seen a lot of shotgun surgery already this week, and it's already Monday. What can we do to bring these patterns into code?
c847a88 to
276e8d0
Compare
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
|
melizeche
added a commit
that referenced
this pull request
Jan 30, 2026
…n-2025.12) (#19777) * Cherry-pick #19768 to version-2025.12 (with conflicts) This cherry-pick has conflicts that need manual resolution. Original PR: #19768 Original commit: f080a82 * Fix type. --------- Co-authored-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com> Co-authored-by: Marcelo Elizeche Landó <marcelo@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 31, 2026
* main: (45 commits) sources/saml: Add testcases for PR #19593 (#19647) revert: website/integrations: wazuh: Change exchange key generation to 64 bytes (#19759) web: bump API Client version (#19760) core: bump djangoql from 0.18.2 to 0.19.1 (#19780) web: Vendor SFE Bootstrap (#19766) core, web: update translations (#19717) web: bump the eslint group across 1 directory with 3 updates (#19782) web: bump the react group across 1 directory with 2 updates (#19784) web: bump country-flag-icons from 1.6.8 to 1.6.9 in /web (#19785) providers/oauth2: Support login_hint (#19498) admin/files: add centralized theme variable support for file URLs (#19657) core: bump github.com/pires/go-proxyproto from 0.9.1 to 0.9.2 (#19778) core: bump openapitools/openapi-diff from 2.1.6 to 2.1.7 in /scripts/api (#19779) core: bump gssapi from 1.10.1 to 1.11.1 (#19781) ci: bump actions/attest-build-provenance from 3.1.0 to 3.2.0 (#19783) website/docs: endpoint devices: fix local device login (#19698) web: Enforce `challenge` nullish types. (#19768) web/elements: stabilize dual-select status height (#19734) web/a11y: CAPTCHA Stage Form (#19670) web/table: align row action icons and tooltip color (#19736) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR enforces the actual type of the
challengeproperty in flow stages, i.e. consistently checking for nullish values.Closes: #19774