sources/saml: Add testcases for PR #19593#19647
Merged
BeryJu merged 1 commit intogoauthentik:mainfrom Jan 27, 2026
Merged
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19647 +/- ##
==========================================
- Coverage 93.28% 93.22% -0.06%
==========================================
Files 949 949
Lines 52131 52163 +32
==========================================
+ Hits 48629 48630 +1
- Misses 3502 3533 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
approved these changes
Jan 27, 2026
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 31, 2026
* main: (45 commits) sources/saml: Add testcases for PR #19593 (#19647) revert: website/integrations: wazuh: Change exchange key generation to 64 bytes (#19759) web: bump API Client version (#19760) core: bump djangoql from 0.18.2 to 0.19.1 (#19780) web: Vendor SFE Bootstrap (#19766) core, web: update translations (#19717) web: bump the eslint group across 1 directory with 3 updates (#19782) web: bump the react group across 1 directory with 2 updates (#19784) web: bump country-flag-icons from 1.6.8 to 1.6.9 in /web (#19785) providers/oauth2: Support login_hint (#19498) admin/files: add centralized theme variable support for file URLs (#19657) core: bump github.com/pires/go-proxyproto from 0.9.1 to 0.9.2 (#19778) core: bump openapitools/openapi-diff from 2.1.6 to 2.1.7 in /scripts/api (#19779) core: bump gssapi from 1.10.1 to 1.11.1 (#19781) ci: bump actions/attest-build-provenance from 3.1.0 to 3.2.0 (#19783) website/docs: endpoint devices: fix local device login (#19698) web: Enforce `challenge` nullish types. (#19768) web/elements: stabilize dual-select status height (#19734) web/a11y: CAPTCHA Stage Form (#19670) web/table: align row action icons and tooltip color (#19736) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The SAML signature issues originally raised in #18176 were addressed and merged in #19593.
While the functional changes look good, I believe the test coverage for
sources/saml/processors/response.py is still insufficient.
This PR adds additional test cases to improve coverage of the signature and encryption handling paths.
The tests and fixtures are largely based on what was prepared in the original PR (#18176), adapted to the current implementation.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)