providers/saml: fix structure of encrypted saml assertion#19592
Merged
PeshekDotDev merged 1 commit intomainfrom Jan 20, 2026
Merged
providers/saml: fix structure of encrypted saml assertion#19592PeshekDotDev merged 1 commit intomainfrom
PeshekDotDev merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19592 +/- ##
==========================================
- Coverage 93.26% 93.21% -0.05%
==========================================
Files 949 949
Lines 52069 52068 -1
==========================================
- Hits 48560 48535 -25
- Misses 3509 3533 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PeshekDotDev
commented
Jan 20, 2026
| self._assertion_id, | ||
| ns=xmlsec.constants.DSigNs, | ||
| ) | ||
| assertion.append(encryption) |
Contributor
Author
There was a problem hiding this comment.
This was appending a blank xenc:EncryptedData that showed up in the decrypted SAML #19585
PeshekDotDev
commented
Jan 20, 2026
|
|
||
| def _encrypt(self, element: Element, parent: Element): | ||
| """Encrypt SAMLResponse EncryptedAssertion Element""" | ||
| # Create a standalone copy so namespace declarations are included in the encrypted content |
Contributor
Author
There was a problem hiding this comment.
This change prevents us from losing the xmlns:saml declaration #19586
BeryJu
approved these changes
Jan 20, 2026
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-76bb57c2d2f3ca0aeb1333b8f0955a61dec4744c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-76bb57c2d2f3ca0aeb1333b8f0955a61dec4744cAfterwards, run the upgrade commands from the latest release notes. |
Contributor
|
🍒 Cherry-pick to |
BeryJu
pushed a commit
that referenced
this pull request
Jan 20, 2026
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 20, 2026
* main: (191 commits) sources/saml: Fix signature verification order to accommodate encrypted assertions (#19593) providers/saml: fix structure of encrypted saml assertion (#19592) providers/saml: allow encryption certificates without private keys (#19526) integrations: add saml steps to mattermost (#19590) policies: fix Provider's authentication_flow not used when set (#19609) web: bump type-fest from 5.4.0 to 5.4.1 in /web (#19473) endpoints: fix endpoints stage marked as enterprise (#19607) core: bump selenium from 4.39.0 to 4.40.0 (#19564) core: bump goauthentik.io/api/v3 from 3.2026020.11 to 3.2026020.12 (#19594) core: bump openapitools/openapi-generator-cli from v7.18.0 to v7.19.0 in /scripts/api (#19595) core: bump fido2 from 2.1.0 to 2.1.1 (#19596) web: bump @sentry/browser from 10.34.0 to 10.35.0 in /web in the sentry group across 1 directory (#19597) core: bump aws-cdk-lib from 2.235.0 to 2.235.1 (#19598) web: bump the eslint group across 1 directory with 3 updates (#19599) web: bump the rollup group across 1 directory with 4 updates (#19600) web: bump the swc group across 1 directory with 12 updates (#19601) web: bump pino from 10.2.0 to 10.2.1 in /web (#19602) web: bump knip from 5.81.0 to 5.82.1 in /web (#19603) tests: improve e2e/integration test reliability (#19540) web: update @goauthentik/api (#19542) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
A couple errors caused encrypted assertions to miss attributes or accidentally have an extra encrypteddata tag inside them after decryption. This pr fixes both of those errors
Closes #19585
Closes #19586
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)