Skip to content

web/flows: use dompurify for footer links#11773

Merged
BeryJu merged 1 commit intomainfrom
web/use-dom-purify
Oct 23, 2024
Merged

web/flows: use dompurify for footer links#11773
BeryJu merged 1 commit intomainfrom
web/use-dom-purify

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 22, 2024

Details

Use DOMPurify for footer


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner October 22, 2024 21:25
@netlify
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 3451b49
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6718188fb3afb800086c856a

@netlify
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 3451b49
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6718188f3784120008a2e0e7
😎 Deploy Preview https://deploy-preview-11773--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the web/use-dom-purify branch from 37bc9a9 to 3451b49 Compare October 22, 2024 21:26
@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (444a068) to head (3451b49).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11773      +/-   ##
==========================================
- Coverage   92.77%   92.69%   -0.08%     
==========================================
  Files         745      745              
  Lines       36943    36943              
==========================================
- Hits        34274    34246      -28     
- Misses       2669     2697      +28     
Flag Coverage Δ
e2e 49.38% <ø> (-0.16%) ⬇️
integration 25.04% <ø> (ø)
unit 90.23% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-3451b497766b0a08eafdc9659c0c483ff6966b9a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-3451b497766b0a08eafdc9659c0c483ff6966b9a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-3451b497766b0a08eafdc9659c0c483ff6966b9a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-3451b497766b0a08eafdc9659c0c483ff6966b9a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit a5a26a5 into main Oct 23, 2024
@BeryJu BeryJu deleted the web/use-dom-purify branch October 23, 2024 09:15
kensternberg-authentik added a commit that referenced this pull request Oct 29, 2024
* main: (44 commits)
  web/admin: add strict dompurify config for diagram (#11783)
  core: bump cryptography from 43.0.1 to 43.0.3 (#11750)
  web: bump API Client version (#11781)
  sources: add Kerberos (#10815)
  root: rework CSRF middleware to set secure flag (#11753)
  web/admin: improve invalidation flow default & field grouping (#11769)
  providers/scim: add comparison with existing group on update and delta update users (#11414)
  website: bump mermaid from 10.6.0 to 10.9.3 in /website (#11766)
  web/flows: use dompurify for footer links (#11773)
  core, web: update translations (#11775)
  core: bump goauthentik.io/api/v3 from 3.2024083.10 to 3.2024083.11 (#11776)
  website: bump @types/react from 18.3.11 to 18.3.12 in /website (#11777)
  website: bump http-proxy-middleware from 2.0.6 to 2.0.7 in /website (#11771)
  web: bump API Client version (#11770)
  stages: authenticator_endpoint_gdtc (#10477)
  core: add prompt_data to auth flow (#11702)
  tests/e2e: fix dex tests failing (#11761)
  web/rac: disable DPI scaling (#11757)
  web/admin: update flow background (#11758)
  website/docs: fix some broken links (#11742)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant