core: add prompt_data to auth flow#11702
Merged
gergosimonyi merged 1 commit intogoauthentik:mainfrom Oct 22, 2024
Merged
Conversation
I added the prompt_data and user_path to the auth flow. This allows us to more easily sync users details whenever they're logged in through a Source by using the Write stage, identical to an Enrolment flow. This makes sure that mappings etc are automatically taken into consideration, and are passed to the Authentication flow. While I was at it, I made the code consistent with the `handle_enroll` method. Signed-off-by: Wouter van Os <wouter0100@gmail.com>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
BeryJu
approved these changes
Oct 21, 2024
rissson
reviewed
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11702 +/- ##
=======================================
Coverage 92.67% 92.68%
=======================================
Files 736 736
Lines 36613 36612 -1
=======================================
Hits 33932 33932
+ Misses 2681 2680 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rissson
approved these changes
Oct 21, 2024
tanberry
pushed a commit
that referenced
this pull request
Oct 22, 2024
I added the prompt_data and user_path to the auth flow. This allows us to more easily sync users details whenever they're logged in through a Source by using the Write stage, identical to an Enrolment flow. This makes sure that mappings etc are automatically taken into consideration, and are passed to the Authentication flow. While I was at it, I made the code consistent with the `handle_enroll` method. Signed-off-by: Wouter van Os <wouter0100@gmail.com>
2 tasks
kensternberg-authentik
added a commit
that referenced
this pull request
Oct 29, 2024
* main: (44 commits) web/admin: add strict dompurify config for diagram (#11783) core: bump cryptography from 43.0.1 to 43.0.3 (#11750) web: bump API Client version (#11781) sources: add Kerberos (#10815) root: rework CSRF middleware to set secure flag (#11753) web/admin: improve invalidation flow default & field grouping (#11769) providers/scim: add comparison with existing group on update and delta update users (#11414) website: bump mermaid from 10.6.0 to 10.9.3 in /website (#11766) web/flows: use dompurify for footer links (#11773) core, web: update translations (#11775) core: bump goauthentik.io/api/v3 from 3.2024083.10 to 3.2024083.11 (#11776) website: bump @types/react from 18.3.11 to 18.3.12 in /website (#11777) website: bump http-proxy-middleware from 2.0.6 to 2.0.7 in /website (#11771) web: bump API Client version (#11770) stages: authenticator_endpoint_gdtc (#10477) core: add prompt_data to auth flow (#11702) tests/e2e: fix dex tests failing (#11761) web/rac: disable DPI scaling (#11757) web/admin: update flow background (#11758) website/docs: fix some broken links (#11742) ...
BeryJu
added a commit
that referenced
this pull request
Nov 12, 2024
* core: add prompt_data to auth flow (#11702) I added the prompt_data and user_path to the auth flow. This allows us to more easily sync users details whenever they're logged in through a Source by using the Write stage, identical to an Enrolment flow. This makes sure that mappings etc are automatically taken into consideration, and are passed to the Authentication flow. While I was at it, I made the code consistent with the `handle_enroll` method. Signed-off-by: Wouter van Os <wouter0100@gmail.com> * updates * and remove errant .py file that somwhow snuck into the PR! also removed errant api ref files remove old images * tweak to bumb build * tweaks * more tweaks * removed extraneous old settings * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * Update website/integrations/services/vmware-vcenter/index.md Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> * formatting * tweak * why not saved before argh --------- Signed-off-by: Wouter van Os <wouter0100@gmail.com> Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com> Co-authored-by: Wouter van Os <wouter0100@gmail.com> Co-authored-by: Tana M Berry <tana@goauthentik.com> Co-authored-by: Jens L. <jens@goauthentik.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
I added the prompt_data and user_path to the auth flow. This allows us to more easily sync users details whenever they're logged in through a Source by using the Write stage, identical to an Enrolment flow (but we should ensure to disable that the Write stage will create new users).
This makes sure that mappings etc are automatically taken into consideration, and are passed to the Authentication flow.
While I was at it, I made the code consistent with the
handle_enrollmethod. I have this change running in production, and it's part of my effort to implement Social logins for customers, as mentioned in this write up (which I have not updated yet, if this is merged I will update it).Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)