stages: authenticator_endpoint_gdtc by BeryJu · Pull Request #10477 · goauthentik/authentik

BeryJu · 2024-07-12T13:04:34Z

Details

Support Chrome Device Trust

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2024-07-12T13:04:50Z

✅ Deploy Preview for authentik-docs canceled.

Name	Link
🔨 Latest commit	`d199420`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/6717a4e1406b220009b28745

netlify · 2024-07-12T13:04:51Z

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	`d199420`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/6717a4e1e51c5b000867bb23

authentik/stages/authenticator_endpoint/views/google_chrome/dtc.py

codecov · 2024-07-23T16:36:02Z

Codecov Report

Attention: Patch coverage is 83.03030% with 28 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (adfa1b1) to head (d199420).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...se/stages/authenticator_endpoint_gdtc/views/dtc.py	44.18%	24 Missing ⚠️
...rprise/stages/authenticator_endpoint_gdtc/stage.py	81.81%	2 Missing ⚠️
authentik/core/api/devices.py	75.00%	1 Missing ⚠️
...prise/stages/authenticator_endpoint_gdtc/models.py	97.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10477      +/-   ##
==========================================
+ Coverage   92.52%   92.69%   +0.16%     
==========================================
  Files         740      745       +5     
  Lines       36783    36944     +161     
==========================================
+ Hits        34034    34245     +211     
+ Misses       2749     2699      -50

Flag	Coverage Δ
e2e	`49.37% <77.57%> (+0.80%)`	⬆️
integration	`25.04% <79.72%> (+0.11%)`	⬆️
unit	`90.23% <83.03%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-18T14:15:57Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d19942056036931bb87b57b6e41b969e7fea1535
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d19942056036931bb87b57b6e41b969e7fea1535-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d19942056036931bb87b57b6e41b969e7fea1535

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d19942056036931bb87b57b6e41b969e7fea1535-arm64

Afterwards, run the upgrade commands from the latest release notes.

notion-workspace · 2024-10-16T16:09:29Z

Google Chrome device trust connector

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

tanberry

A couple of nits and a question... I'm approving now so that I am not the bottleneck. :-)

website/docs/add-secure-apps/flows-stages/stages/authenticator_endpoint_gdtc/index.md

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Jens L. <jens@beryju.org>

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* main: (44 commits) web/admin: add strict dompurify config for diagram (#11783) core: bump cryptography from 43.0.1 to 43.0.3 (#11750) web: bump API Client version (#11781) sources: add Kerberos (#10815) root: rework CSRF middleware to set secure flag (#11753) web/admin: improve invalidation flow default & field grouping (#11769) providers/scim: add comparison with existing group on update and delta update users (#11414) website: bump mermaid from 10.6.0 to 10.9.3 in /website (#11766) web/flows: use dompurify for footer links (#11773) core, web: update translations (#11775) core: bump goauthentik.io/api/v3 from 3.2024083.10 to 3.2024083.11 (#11776) website: bump @types/react from 18.3.11 to 18.3.12 in /website (#11777) website: bump http-proxy-middleware from 2.0.6 to 2.0.7 in /website (#11771) web: bump API Client version (#11770) stages: authenticator_endpoint_gdtc (#10477) core: add prompt_data to auth flow (#11702) tests/e2e: fix dex tests failing (#11761) web/rac: disable DPI scaling (#11757) web/admin: update flow background (#11758) website/docs: fix some broken links (#11742) ...

BeryJu requested review from a team as code owners July 12, 2024 13:04

BeryJu marked this pull request as draft July 12, 2024 13:04

github-advanced-security bot found potential problems Jul 12, 2024

View reviewed changes

authentik/stages/authenticator_endpoint/views/google_chrome/dtc.py Fixed Show fixed Hide fixed

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 2 times, most recently from a041ead to a938629 Compare July 13, 2024 13:29

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from a938629 to 78866da Compare July 23, 2024 16:27

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 4 times, most recently from c6ebbd9 to b564f69 Compare August 18, 2024 13:37

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 2 times, most recently from e2360c7 to 34bc604 Compare September 24, 2024 15:55

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 5 times, most recently from cdb7010 to 1e3a27b Compare October 16, 2024 15:24

BeryJu marked this pull request as ready for review October 16, 2024 16:20

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from 1e3a27b to 259e83a Compare October 18, 2024 17:15

BeryJu added 2 commits October 21, 2024 16:18

rework

bba85a0

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add loading overlay for chrome

bc0573a

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from ade82a0 to bc0573a Compare October 21, 2024 14:18

start docs

bc00c25

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu requested a review from a team as a code owner October 21, 2024 15:42

tanberry approved these changes Oct 21, 2024

View reviewed changes

BeryJu and others added 5 commits October 22, 2024 14:16

Apply suggestions from code review

2edfd35

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Jens L. <jens@beryju.org>

save data

fd6ccaf

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix web ui, prevent deletion

47866de

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix

f20f060

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

text fixes

d199420

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from 478acf2 to d199420 Compare October 22, 2024 13:13

BeryJu merged commit cec3fdb into main Oct 22, 2024

BeryJu deleted the stages/authenticator_endpoint_gdtc branch October 22, 2024 20:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stages: authenticator_endpoint_gdtc#10477

stages: authenticator_endpoint_gdtc#10477
BeryJu merged 8 commits intomainfrom
stages/authenticator_endpoint_gdtc

BeryJu commented Jul 12, 2024 •

edited by fheisler

Loading

Uh oh!

netlify bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

netlify bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jul 23, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 18, 2024 •

edited

Loading

Uh oh!

notion-workspace bot commented Oct 16, 2024

Uh oh!

tanberry left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BeryJu commented Jul 12, 2024 • edited by fheisler Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Checklist

Uh oh!

netlify bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-docs canceled.

Uh oh!

netlify bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook canceled.

Uh oh!

Uh oh!

codecov bot commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notion-workspace bot commented Oct 16, 2024

Uh oh!

tanberry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BeryJu commented Jul 12, 2024 •

edited by fheisler

Loading

netlify bot commented Jul 12, 2024 •

edited

Loading

netlify bot commented Jul 12, 2024 •

edited

Loading

codecov bot commented Jul 23, 2024 •

edited

Loading

github-actions bot commented Aug 18, 2024 •

edited

Loading