Skip to content

providers/scim: add comparison with existing group on update and delta update users#11414

Merged
BeryJu merged 6 commits intomainfrom
providers/scim/better-patch-support
Oct 23, 2024
Merged

providers/scim: add comparison with existing group on update and delta update users#11414
BeryJu merged 6 commits intomainfrom
providers/scim/better-patch-support

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 17, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners September 17, 2024 12:22
@netlify
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 40ed845
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6710f1cba1bb5d0008cc4afc

@netlify
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 40ed845
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6710f1cb1b3fe40008a891f7

@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 18 lines in your changes missing coverage. Please review.

Project coverage is 92.74%. Comparing base (ec2d631) to head (40ed845).
Report is 122 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/providers/scim/clients/groups.py 63.82% 17 Missing ⚠️
authentik/lib/utils/http.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11414      +/-   ##
==========================================
+ Coverage   92.69%   92.74%   +0.05%     
==========================================
  Files         736      736              
  Lines       36542    36675     +133     
==========================================
+ Hits        33871    34015     +144     
+ Misses       2671     2660      -11     
Flag Coverage Δ
e2e 49.30% <3.40%> (+0.14%) ⬆️
integration 24.91% <0.00%> (-0.07%) ⬇️
unit 90.20% <79.54%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the providers/scim/better-patch-support branch from 515662e to 5f95b5a Compare September 17, 2024 13:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-40ed8459561f1457286f4871159f269d83659bee
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-40ed8459561f1457286f4871159f269d83659bee-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-40ed8459561f1457286f4871159f269d83659bee

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-40ed8459561f1457286f4871159f269d83659bee-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the providers/scim/better-patch-support branch 2 times, most recently from 875721d to 315a4e0 Compare September 17, 2024 15:48
@BeryJu BeryJu added this to the Release 2024.8.3 milestone Sep 26, 2024
BeryJu added 4 commits October 1, 2024 12:41
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
…a update users

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/scim/better-patch-support branch from 461feaf to ae884b0 Compare October 1, 2024 11:10
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit d3d96b7 into main Oct 23, 2024
@BeryJu BeryJu deleted the providers/scim/better-patch-support branch October 23, 2024 10:39
@BeryJu
Copy link
Member Author

BeryJu commented Oct 24, 2024

/cherry-pick version-2024.8

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 24, 2024
…a update users (#11414)

* fix incorrect default group mapping

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* providers/scim: add comparison with existing group on update and delta update users

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix another exception when creating groups

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix users to add check

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Oct 24, 2024
…a update users (cherry-pick #11414) (#11796)

providers/scim: add comparison with existing group on update and delta update users (#11414)

* fix incorrect default group mapping



* providers/scim: add comparison with existing group on update and delta update users



* fix



* fix



* fix another exception when creating groups



* fix users to add check



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Oct 29, 2024
* main: (44 commits)
  web/admin: add strict dompurify config for diagram (#11783)
  core: bump cryptography from 43.0.1 to 43.0.3 (#11750)
  web: bump API Client version (#11781)
  sources: add Kerberos (#10815)
  root: rework CSRF middleware to set secure flag (#11753)
  web/admin: improve invalidation flow default & field grouping (#11769)
  providers/scim: add comparison with existing group on update and delta update users (#11414)
  website: bump mermaid from 10.6.0 to 10.9.3 in /website (#11766)
  web/flows: use dompurify for footer links (#11773)
  core, web: update translations (#11775)
  core: bump goauthentik.io/api/v3 from 3.2024083.10 to 3.2024083.11 (#11776)
  website: bump @types/react from 18.3.11 to 18.3.12 in /website (#11777)
  website: bump http-proxy-middleware from 2.0.6 to 2.0.7 in /website (#11771)
  web: bump API Client version (#11770)
  stages: authenticator_endpoint_gdtc (#10477)
  core: add prompt_data to auth flow (#11702)
  tests/e2e: fix dex tests failing (#11761)
  web/rac: disable DPI scaling (#11757)
  web/admin: update flow background (#11758)
  website/docs: fix some broken links (#11742)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants