Skip to content

Improve the Street Smart plugin view for 3D maps visualization #11374#11375

Merged
allyoucanmap merged 3 commits intogeosolutions-it:masterfrom
rowheat02:fix/streetviewissue
Aug 25, 2025
Merged

Improve the Street Smart plugin view for 3D maps visualization #11374#11375
allyoucanmap merged 3 commits intogeosolutions-it:masterfrom
rowheat02:fix/streetviewissue

Conversation

@rowheat02
Copy link
Copy Markdown
Contributor

@rowheat02 rowheat02 commented Aug 6, 2025

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

fixes #11374

What is the current behavior?

#11374
While using the Street Smart plugin on 3D, the WFS call was not appropriately made at a tilted camera angle.

What is the new behavior?

  • A new Strategy was introduced, named "tile" for the WFS layer, which
    • dynamically creates and manages custom tiles in 3d, and calls the WFS api on each tile
    • Same on OpenLayers, but OpenLayers itself manages the tiles; we only needed to give tileSize
  • After the new strategy, in 3d, also in any tilt camera angle, api is called, and are rendered after the view is changed
  • On Streetview of the CYCLOMEDIA, on level 17, tiles start to be created in 3d
Screen.Recording.2025-08-06.at.11.59.16.mov

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

  1. As extent was being sent only to Server type: no-vendor on both openlayers and cesium, so 'tile' strategy for wfs is only for no-vendor.
  2. As for the "tile" strategy, features are managed on the Cesium billboard; on Cesium, only WFS with point features will be managed. But for OpenLayers, the tile strategy works for any geometric type.
  3. For mark and icon of symbolizerToPrimitives, src is used instead of image for better performance.
  4. From our last call, terrainProvider undefined in some cases was solved after the cleanup; now we always get a terrain provider for Street View WFS.
  5. setStyleFunction on web/client/utils/cesium/TiledBillboardCollection.js is tested programmatically. Since we agreed to define tiledPrimitive inside the add function, and also not returned from the add function, we dont have access to it in update method. If declared before the add function and returned by the add function, it can be used to update the style inside the update method of WFSLayer.
        // update style for tile strategy
        if (newOptions.strategy === 'tile' && !isEqual(newOptions.style, oldOptions.style)) {
            layer.tiledPrimitive.setStyleFunction(newOptions.style);
         }
    
    Since for street view, a dynamic styling update is not required, setStyleFunction will only remain inside TiledBillboardCollection, which may be used later.
  • can be tested on dev server resource: context/cyclo3d_test/59425

@rowheat02 rowheat02 self-assigned this Aug 6, 2025
@rowheat02 rowheat02 added this to the 2025.02.00 milestone Aug 6, 2025
@rowheat02 rowheat02 requested a review from allyoucanmap August 6, 2025 07:12
@rowheat02 rowheat02 marked this pull request as ready for review August 6, 2025 07:12
@allyoucanmap allyoucanmap merged commit 922747a into geosolutions-it:master Aug 25, 2025
6 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

@ElenaGallo please test this enhancement on dev, thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Sep 9, 2025
…tinerary

* commit 'ea419127df12f794a56f234f5660632511df7484':
  Update README.md
  Proj4 upgrade and include support for "Grid Based Datum Adjustments" geosolutions-it#11423 (geosolutions-it#11424)
  Bom versions for maven-war-plugin in all POMs.xml (geosolutions-it#11413)
  Fix geosolutions-it#11419 fixed group translation files (geosolutions-it#11420)
  Update geoserver.md (geosolutions-it#11399)
  Bump org.apache.tomcat:tomcat-coyote from 9.0.105 to 9.0.108 in /binary (geosolutions-it#11384)
  Update on the Swedish translation file for MapStore (geosolutions-it#11412)
  Fix geosolutions-it#11258 :For clipping/masking 3D tiles and terrain removed ClippingPlaneCollection and introduced ClippingPolygonCollection (geosolutions-it#11352)
  Fix : geosolutions-it#11400 Added quickFilters also  when exporting data from TableWidget (geosolutions-it#11401)
  Fix geosolutions-it#11404 Problem with user permissions still involving the "Save As" (geosolutions-it#11408)
  Fix geosolutions-it#11406 Pending changes prompt shows up after save as (geosolutions-it#11407)
  Fix geosolutions-it#11374 Improve the Street Smart plugin view for 3D maps visualization (geosolutions-it#11375)
  Update i18n showEmptyMessageGFI (geosolutions-it#11392)
  geosolutions-it#11369: Enhance non hyperlink query field to have spacing (geosolutions-it#11370)
  Bump org.apache.tomcat:tomcat-util from 9.0.105 to 9.0.107 in /binary (geosolutions-it#11305)
  chore: Remove element-closest dependency (geosolutions-it#11251)
  Fix the widget support for the WFS layer with no geom (geosolutions-it#11379)
  Support of widget in map even when layer have no geometry and fix time dependencies for the widget (geosolutions-it#11377)
  Performace Lag when there is a layer with very large geomerty geosolutions-it#11358 (geosolutions-it#11359)
  skip click on layer should return intersected features test on Cesium tests (geosolutions-it#11365)
@ElenaGallo
Copy link
Copy Markdown
Contributor

@rowheat02 testing this, I found the follows:

  • When Ilogin with a wrong username and password on street smart plugin and error occurs and it is no lonegr possible to login on the plugin
street_smart.mp4

How to reproduce

-Open this context: https://dev-mapstore.geosolutionsgroup.com/mapstore/#/context/cyclo3d_test/59425

  • Click on Street view
  • Enter wrong user/password

Expected Result
A warning error appears but than i can try to do a login again

Current Result
A red page opens and i can not login anymore

@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed. @rowheat02 please backport to 2025.02.xx. Thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Nov 18, 2025
… maps visualization (geosolutions-it#11375)

---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
tdipisa pushed a commit that referenced this pull request Nov 18, 2025
…plugin view for 3D maps visualization (#11695)

* Fix #11374 Improve the Street Smart plugin view for 3D maps visualization (#11375)


---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>

* Improve the Street Smart plugin view for 3D maps visualization(Re-login enabled) #11374 (#11628)

---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the Street Smart plugin view for 3D maps visualization

4 participants