Support of widget in map even when layer have no geometry and fix time dependencies for the widget#11377
Merged
offtherailz merged 6 commits intogeosolutions-it:masterfrom Aug 8, 2025
Conversation
offtherailz
reviewed
Aug 8, 2025
…10/MapStore2 into fix/chart-dimension-issue
offtherailz
reviewed
Aug 8, 2025
web/client/epics/widgets.js
Outdated
Comment on lines
+73
to
+79
| if (!endsWith(targetId, "map") && includes(tableDependencies, k) && !includes(dimensionDependencies, k)) { | ||
| return { | ||
| ...ov, | ||
| [k]: `${targetId}.${mappings[k]}` | ||
| }; | ||
| } | ||
| if (endsWith(targetId, "map")) { | ||
| if (endsWith(targetId, "map") && !includes(dimensionDependencies, k)) { |
Member
There was a problem hiding this comment.
I think this can be removed, because !includes already returns.
Suggested change
| if (!endsWith(targetId, "map") && includes(tableDependencies, k) && !includes(dimensionDependencies, k)) { | |
| return { | |
| ...ov, | |
| [k]: `${targetId}.${mappings[k]}` | |
| }; | |
| } | |
| if (endsWith(targetId, "map")) { | |
| if (endsWith(targetId, "map") && !includes(dimensionDependencies, k)) { | |
| if (!endsWith(targetId, "map") && includes(tableDependencies, k)) { | |
| return { | |
| ...ov, | |
| [k]: `${targetId}.${mappings[k]}` | |
| }; | |
| } | |
| if (endsWith(targetId, "map")) { |
offtherailz
reviewed
Aug 8, 2025
web/client/epics/widgets.js
Outdated
| [k]: `${depToTheWidget}.${mappings[k]}` | ||
| }; | ||
| } | ||
|
|
offtherailz
approved these changes
Aug 8, 2025
subashtiwari1010
added a commit
to subashtiwari1010/MapStore2
that referenced
this pull request
Aug 8, 2025
…e dependencies for the widget (geosolutions-it#11377)
12 tasks
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Sep 9, 2025
…tinerary * commit 'ea419127df12f794a56f234f5660632511df7484': Update README.md Proj4 upgrade and include support for "Grid Based Datum Adjustments" geosolutions-it#11423 (geosolutions-it#11424) Bom versions for maven-war-plugin in all POMs.xml (geosolutions-it#11413) Fix geosolutions-it#11419 fixed group translation files (geosolutions-it#11420) Update geoserver.md (geosolutions-it#11399) Bump org.apache.tomcat:tomcat-coyote from 9.0.105 to 9.0.108 in /binary (geosolutions-it#11384) Update on the Swedish translation file for MapStore (geosolutions-it#11412) Fix geosolutions-it#11258 :For clipping/masking 3D tiles and terrain removed ClippingPlaneCollection and introduced ClippingPolygonCollection (geosolutions-it#11352) Fix : geosolutions-it#11400 Added quickFilters also when exporting data from TableWidget (geosolutions-it#11401) Fix geosolutions-it#11404 Problem with user permissions still involving the "Save As" (geosolutions-it#11408) Fix geosolutions-it#11406 Pending changes prompt shows up after save as (geosolutions-it#11407) Fix geosolutions-it#11374 Improve the Street Smart plugin view for 3D maps visualization (geosolutions-it#11375) Update i18n showEmptyMessageGFI (geosolutions-it#11392) geosolutions-it#11369: Enhance non hyperlink query field to have spacing (geosolutions-it#11370) Bump org.apache.tomcat:tomcat-util from 9.0.105 to 9.0.107 in /binary (geosolutions-it#11305) chore: Remove element-closest dependency (geosolutions-it#11251) Fix the widget support for the WFS layer with no geom (geosolutions-it#11379) Support of widget in map even when layer have no geometry and fix time dependencies for the widget (geosolutions-it#11377) Performace Lag when there is a layer with very large geomerty geosolutions-it#11358 (geosolutions-it#11359) skip click on layer should return intersected features test on Cesium tests (geosolutions-it#11365)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #11376. It adds the support of the widget for the layer with no geometry and fixes the issue of time dependencies when the map connection disabled and re-enabled.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
When the layer is added in the map with no geometry, then there is error for that layer (as it does not have any geometry). So, the creation of the widget is not available for it. But, when the same layer is added to the dashboard, then the widget can be created for that layer using other fields.
Also, for the current time in the widget, when the map connection is disabled and re-enabled, then the current time shape disappears from the widget.
Fixes #11376
What is the new behavior?
Even if the layer does not have any geometry, the widget can be created just like in the dashboard. But for such case, the connection with the map is disabled so no geometry filtering applies and the widget can be displayed properly.
Also, for the current time, even if the connection is toggled, the current time will be visible.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information