Skip to content

Fix : #11400 Added quickFilters also when exporting data from TableWidget#11401

Merged
MV88 merged 2 commits intogeosolutions-it:masterfrom
anup39:fix_quickfilter_11400
Aug 28, 2025
Merged

Fix : #11400 Added quickFilters also when exporting data from TableWidget#11401
MV88 merged 2 commits intogeosolutions-it:masterfrom
anup39:fix_quickfilter_11400

Conversation

@anup39
Copy link
Copy Markdown
Member

@anup39 anup39 commented Aug 25, 2025

Description

When exporting the data from the TableWidget , quickFilters are also included

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Enhancement

Issue

What is the current behavior?

#11400

What is the new behavior?

When exporting the data now , both the quick filter and filter configured in the widget is included.

Screenshot 2025-08-25 at 14 26 27

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@anup39 anup39 added this to the 2025.01.02 milestone Aug 25, 2025
@anup39 anup39 requested a review from MV88 August 25, 2025 08:46
@anup39 anup39 self-assigned this Aug 25, 2025
@anup39 anup39 linked an issue Aug 25, 2025 that may be closed by this pull request
Include quickFilters when exporting data from TableWidget. #11400
Closed
@anup39 anup39 changed the title Fix : #11400 Added quickFilters also when exporting data from TableWiget Fix : #11400 Added quickFilters also when exporting data from TableWidget Aug 25, 2025
MV88
MV88 requested changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment •
edited by anup39
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • functionality wise looks to be working in the dashboard page, but when downloading from the map it is downloading the entire set
image and not just the 10 items
  • Also please add a unit test covering this case for the selector chagned

@anup39
Copy link
Copy Markdown
Member Author

anup39 commented Aug 25, 2025

  • functionality wise looks to be working in the dashboard page, but when downloading from the map it is downloading the entire set

image and not just the 10 items

  • Also please add a unit test covering this case for the selector chagned

@MV88 @tdipisa Upon checking it seems like in Map Page quickFilters does not include geometry filtering (only attributes). In map page the data is filtered according to the current extent(geometry) . In this case we are not updating the quick filter with the new geometry every time . This is the reason in map page you are getting full datasets when you export. In the production also it is behaving the same. From my understanding this should be addressed in the new separate issue.

@anup39 anup39 requested a review from MV88 August 25, 2025 16:36
@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Aug 28, 2025

  • functionality wise looks to be working in the dashboard page, but when downloading from the map it is downloading the entire set

image and not just the 10 items

  • Also please add a unit test covering this case for the selector chagned

@MV88 @tdipisa Upon checking it seems like in Map Page quickFilters does not include geometry filtering (only attributes). In map page the data is filtered according to the current extent(geometry) . In this case we are not updating the quick filter with the new geometry every time . This is the reason in map page you are getting full datasets when you export. In the production also it is behaving the same. From my understanding this should be addressed in the new separate issue.

@anup39
I agree this might be addressed into a separate issue, but let me rephrase a bit. The quickFilters you mention are the input field that are placed on the second row, and these are stored usually in a quickFilters property. Other filters like the spatial one applied to the layer in the map viewer or other attribute filters, are stored into layerFilter (ie. as a global filter on this layer).
I think that if a global filter is active and applied to the map it should be used also in other tools like download etc. for consistency.
So yes please create a new issue specifying these things

@tdipisa FYI

MV88
MV88 approved these changes Aug 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this then

@MV88 MV88 merged commit fd709e7 into geosolutions-it:master Aug 28, 2025
6 checks passed
@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Aug 28, 2025

@ElenaGallo please test it in DEV

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Aug 28, 2025
@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Aug 28, 2025

Test passed, @anup39 please backport to 2025.01.xx. Thanks

anup39 added a commit to anup39/MapStore2 that referenced this pull request Aug 29, 2025
@anup39
Fix : geosolutions-it#11400 Added quickFilters also when exporting da…
764c08d 
…ta from TableWidget (geosolutions-it#11401)

* Fix : geosolutions-it#11400 Added quickFilters also  when exporting data from TableWiget

* Added unit test for quick filter when exporting the layer data
tdipisa pushed a commit that referenced this pull request Aug 29, 2025
@anup39
Fix : #11400 Added quickFilters also when exporting data from TableWi…
d64040f 
…dget (#11401) (#11414)

* Fix : #11400 Added quickFilters also  when exporting data from TableWiget

* Added unit test for quick filter when exporting the layer data
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Aug 29, 2025
dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Sep 9, 2025
@dsuren1
Merge commit 'ea419127df12f794a56f234f5660632511df7484' into #11387_i…
3b763ad 
…tinerary

* commit 'ea419127df12f794a56f234f5660632511df7484':
  Update README.md
  Proj4 upgrade and include support for "Grid Based Datum Adjustments" geosolutions-it#11423 (geosolutions-it#11424)
  Bom versions for maven-war-plugin in all POMs.xml (geosolutions-it#11413)
  Fix geosolutions-it#11419 fixed group translation files (geosolutions-it#11420)
  Update geoserver.md (geosolutions-it#11399)
  Bump org.apache.tomcat:tomcat-coyote from 9.0.105 to 9.0.108 in /binary (geosolutions-it#11384)
  Update on the Swedish translation file for MapStore (geosolutions-it#11412)
  Fix geosolutions-it#11258 :For clipping/masking 3D tiles and terrain removed ClippingPlaneCollection and introduced ClippingPolygonCollection (geosolutions-it#11352)
  Fix : geosolutions-it#11400 Added quickFilters also  when exporting data from TableWidget (geosolutions-it#11401)
  Fix geosolutions-it#11404 Problem with user permissions still involving the "Save As" (geosolutions-it#11408)
  Fix geosolutions-it#11406 Pending changes prompt shows up after save as (geosolutions-it#11407)
  Fix geosolutions-it#11374 Improve the Street Smart plugin view for 3D maps visualization (geosolutions-it#11375)
  Update i18n showEmptyMessageGFI (geosolutions-it#11392)
  geosolutions-it#11369: Enhance non hyperlink query field to have spacing (geosolutions-it#11370)
  Bump org.apache.tomcat:tomcat-util from 9.0.105 to 9.0.107 in /binary (geosolutions-it#11305)
  chore: Remove element-closest dependency (geosolutions-it#11251)
  Fix the widget support for the WFS layer with no geom (geosolutions-it#11379)
  Support of widget in map even when layer have no geometry and fix time dependencies for the widget (geosolutions-it#11377)
  Performace Lag when there is a layer with very large geomerty geosolutions-it#11358 (geosolutions-it#11359)
  skip click on layer should return intersected features test on Cesium tests (geosolutions-it#11365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@anup39 anup39

Labels

enhancement

Projects

None yet

Milestone

2025.01.02

Development

Successfully merging this pull request may close these issues.

Include quickFilters when exporting data from TableWidget.

5 participants

@anup39 @MV88 @ElenaGallo @tdipisa @MariaBanti