Skip to content

Improve the Street Smart plugin view for 3D maps visualization(Re-login enabled) #11374#11628

Merged
allyoucanmap merged 3 commits intogeosolutions-it:masterfrom
rowheat02:streetviewerror
Nov 4, 2025
Merged

Improve the Street Smart plugin view for 3D maps visualization(Re-login enabled) #11374#11628
allyoucanmap merged 3 commits intogeosolutions-it:masterfrom
rowheat02:streetviewerror

Conversation

@rowheat02
Copy link
Copy Markdown
Contributor

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Done as part of this issue #11374. Reported here #11375 (comment)

What is the current behavior?

When entering invalid credentials, user was not able to re-login

What is the new behavior?

The user will see the Relogin button when invalid credentials is entered.
image

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2025.02.00 milestone Oct 24, 2025
@rowheat02 rowheat02 linked an issue Oct 24, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa requested a review from allyoucanmap October 24, 2025 13:15
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 4, 2025
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rowheat02 it will be better to show directly credentials form with the error message instead of showing a button to reload the inputs, e.g. :

image

@rowheat02
Copy link
Copy Markdown
Contributor Author

rowheat02 commented Nov 4, 2025

Now, when the user enters invalid credentials, the credential form and error message will be shown directly.
image

  • Cancel Button will not be shown on the credential from when wrong credentials are entered already.

@allyoucanmap allyoucanmap merged commit 5b493fb into geosolutions-it:master Nov 4, 2025
6 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

@ElenaGallo please test this fix on dev and let us know if we can backport to 2025.02.xx, thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Nov 18, 2025
@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 18, 2025
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Nov 18, 2025

@ElenaGallo can we finally backport this to 2025.02.xx?

tdipisa pushed a commit that referenced this pull request Nov 18, 2025
…plugin view for 3D maps visualization (#11695)

* Fix #11374 Improve the Street Smart plugin view for 3D maps visualization (#11375)


---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>

* Improve the Street Smart plugin view for 3D maps visualization(Re-login enabled) #11374 (#11628)

---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
@ElenaGallo
Copy link
Copy Markdown
Contributor

@ElenaGallo can we finally backport this to 2025.02.xx?

Yes, @allyoucanmap please backport to 2025.02.xx. Thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Nov 18, 2025
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the Street Smart plugin view for 3D maps visualization

4 participants