#11120: Fix - Counter widget error when connected to a Table in dashboard#11244
Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom Jun 27, 2025
Merged
#11120: Fix - Counter widget error when connected to a Table in dashboard#11244allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
Conversation
… Table in dashboard
Contributor
Author
|
Warning Unit test error is not related to this PR |
* fix_icon: fix FE unit tests failure due to change in PR 11236 (geosolutions-it#11245) geosolutions-it#10839: Allow printing by freely setting the scale factor (geosolutions-it#11130) Annotation/Measurement not shown in the legend of the printred map geosolutions-it#11235 (geosolutions-it#11236)
allyoucanmap
approved these changes
Jun 27, 2025
Contributor
|
@ElenaGallo please test this fix on dev and let us know if we can backport to 2025.01.xx and 2024.02.xx, thanks |
Contributor
|
@allyoucanmap @dsuren1 I've just tested on https://dev-mapstore.geosolutionsgroup.com/ and I still see the problem if I do the same steps described in the issue #11120
|
5 tasks
Contributor
Author
|
@allyoucanmap @giohappy |
Member
|
@ElenaGallo once done this need to be backported to both 2024.02.xx and 2025.01.xx |
Contributor
|
Test passed, @dsuren1 please backport to 2025.01.xx. Thanks |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Jul 10, 2025
… Table in dashboard (geosolutions-it#11244) (cherry picked from commit 6a59eb3)
tdipisa
pushed a commit
that referenced
this pull request
Jul 11, 2025
…ed to a Table in dashboard (#11244) (#11301) * #11120: Fix - Counter widget error when connected to a Table in dashboard (#11244) (cherry picked from commit 6a59eb3) * #11120: Skip dependency filter generation when filter parts are empty (#11271) (cherry picked from commit 30fb2bc) * #11282: Fix - Chart builder in map viewer is not working (#11283) (cherry picked from commit fac32bc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the parsing error caused when empty ogc filter is send in the payload. Also corrects the tooltip on connect button based on the dependencies available
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
The counter widget when connected to table doesn't throw any parse error and the counter is updated correctly. All the dependency features are preserved for counter widget
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information