Skip to content

#11120: Skip dependency filter generation when filter parts are empty#11271

Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
dsuren1:#11120_fix
Jul 10, 2025
Merged

#11120: Skip dependency filter generation when filter parts are empty#11271
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
dsuren1:#11120_fix

Conversation

@dsuren1
Copy link
Copy Markdown
Contributor

@dsuren1 dsuren1 commented Jul 2, 2025

Description

This PR fixes an issue where certain filter parts being empty resulted in an empty OGC filter being sent

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2024.02.03 milestone Jul 2, 2025
@dsuren1 dsuren1 self-assigned this Jul 2, 2025
@dsuren1 dsuren1 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jul 2, 2025
@dsuren1
Copy link
Copy Markdown
Contributor Author

dsuren1 commented Jul 10, 2025

@allyoucanmap @ElenaGallo

FYI, this PR is dependent on the issue #11120, the following PRs #11283 #11244 are all related and must tested combinedly and backported to 2025.01.xx and 2024.02.xx . Thanks!

@allyoucanmap allyoucanmap merged commit 30fb2bc into geosolutions-it:master Jul 10, 2025
6 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

@ElenaGallo please test this fix on dev and let use know when we can backport, thanks

@ElenaGallo
Copy link
Copy Markdown
Contributor

Test passed, @dsuren1 please backport to 2025.01.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jul 10, 2025
tdipisa pushed a commit that referenced this pull request Jul 11, 2025
…ed to a Table in dashboard (#11244) (#11301)

* #11120: Fix - Counter widget error when connected to a Table in dashboard (#11244)

(cherry picked from commit 6a59eb3)

* #11120: Skip dependency filter generation when filter parts are empty (#11271)

(cherry picked from commit 30fb2bc)

* #11282: Fix - Chart builder in map viewer is not working (#11283)

(cherry picked from commit fac32bc)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Counter Widget error when connected to a Table without a filter applied inside dashboards

4 participants