fix FE unit tests failure due to change in PR 11236#11245
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Jun 26, 2025
Merged
fix FE unit tests failure due to change in PR 11236#11245offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
offtherailz
approved these changes
Jun 26, 2025
12 tasks
Contributor
|
Test passed, @mahmoudadel54 please backport to 2025.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jun 26, 2025
Contributor
Author
Backport is done --> #11247 |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Jun 27, 2025
* fix_icon: fix FE unit tests failure due to change in PR 11236 (geosolutions-it#11245) geosolutions-it#10839: Allow printing by freely setting the scale factor (geosolutions-it#11130) Annotation/Measurement not shown in the legend of the printred map geosolutions-it#11235 (geosolutions-it#11236)
offtherailz
pushed a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes only fixing unit tests failure happened due merge process of subsequent PRs'.
The cause of the failing is a change implemented in return of getMapfishPrintSpecification in this PR --> returns promise: #11236 and it merged first before #11130 which contains additional unit tests [that failed] uses the previous version of getMapfishPrintSpecification that not return promise.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
Compendium fix #10839