Annotation/Measurement not shown in the legend of the printred map #11235#11236
Merged
offtherailz merged 6 commits intogeosolutions-it:masterfrom Jun 25, 2025
Merged
Conversation
offtherailz
requested changes
Jun 23, 2025
Member
offtherailz
left a comment
There was a problem hiding this comment.
Going to test when using promises.
POlease also fix object-assign usage.
f3d6783 to
e16bfc2
Compare
1 task
offtherailz
requested changes
Jun 24, 2025
Member
There was a problem hiding this comment.
The result looked good
Anyway at a certain point I started having these errors:
- I started having results and it was quite good, but at a certain time, I had this error.
Error inlining remote css file SecurityError: Failed to read the 'cssRules' property from 'CSSStyleSheet': Cannot access rules
at eval (embed-webfonts.js:91:70)
at Array.forEach (<anonymous>)
at getCSSRules (embed-webfonts.js:88:17)
at parseWebFontRules (embed-webfonts.js:160:28)
at getWebFontCSS (embed-webfonts.js:164:25)
at embedWebFonts (embed-webfonts.js:176:21)
at toSvg (index.js:24:73)
at async toCanvas (index.js:32:17)
at async Object.toPng (index.js:60:20)
at async Promise.all (:8081/index 1)
Here the video:
Video.del.2025-06-24.09-48-25.mp4
Video.del.2025-06-24.09-56-00.mp4
after a lot of seconds, I receive also this error by the server, but this is probably due to the first error, I report it only for completeness:
offtherailz
approved these changes
Jun 25, 2025
Contributor
|
Test passed, @rowheat02 please backport to 2025.01.xx. Thanks |
12 tasks
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Jun 27, 2025
* fix_icon: fix FE unit tests failure due to change in PR 11236 (geosolutions-it#11245) geosolutions-it#10839: Allow printing by freely setting the scale factor (geosolutions-it#11130) Annotation/Measurement not shown in the legend of the printred map geosolutions-it#11235 (geosolutions-it#11236)
rowheat02
added a commit
to rowheat02/MapStore2
that referenced
this pull request
Jun 27, 2025
offtherailz
pushed a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The print export of the map with vector layers was missing the legend of vector layers(annotation, measurement). This PR includes the legends of vector layers on print export.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
fixes #11235
What is the current behavior?
#11235
Annotations and measurements (vector layers) are not shown in the legend on the exported print
What is the new behavior?
Annotations and measurements(vector layers) should be shown in the legend on the exported print
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information