Conversation
fixing trivial link error in doc
Wrap Swiss flag in div to better center it, this way its position centered in the space it is given
in order to enable the content of the header to be vertically centered by the flexbox. Otherwise, as it was also present in the same container as the search bar, the height of the disclaimer was taken into account when placing the search bar input at the vertical center of the header. This then covers what was intended for the ticket BGDIINF_SB-2259
…swiss_flag BGDIINF_SB-2784 : fix Swiss flag position on smaller devices
whenever we show the lightbasemap layer behind pixelkarte-farbe, with the new extent detection we were not going through the standard layer pipeline, so we also need to add an exception in the attribution management for this case
…p_copyrights BGDIINF_SB-2783 : add back light base map copyrights
Give the user a visual feedback if the email he wrote is malformed. Only check format when the user has left the input, so that it doesn't start checking after first letter is typed in (and as a single letter is a malformed email it would directly give a bad feedback to the user who has not yet written anything...) Also fixing a little bug where when closing the feedback modal by clicking on the transparent backdrop would not clear inputs.
So that when the user has sent his feedback, we can also show visually that the rating is disabled and no more feedback can be edited in this instance of the feedback form
And only show a text telling the user the message was sent. Disable all inputs while a request is pending
…d_feedback BGDIINF_SB-2769 : add email input in feedback form
Updating translations for search bar
When going in fullscreen mode, the banner now does not appear cut anymore.
…est-banner-to-cover-screen-under-head BGDIINF_SB-2790: Test banner now covers screen under the header
In desktop mode, do not hide the menu anymore when showing search results, but still do that in phone mode.
To make both the menu and the search results visible at the same time, above the size lg, the search bar starts after the menu tray so that the search results do not overlap with the menu.
…back-after-search-results-hidden BGDIINF_SB-2793: leave menu open when searching
ltshb
reviewed
Feb 21, 2023
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Good but wait that I changed the auto deploy on test.map.geo.admin.ch script.
Contributor
ltshb
approved these changes
Feb 21, 2023
Contributor
ltshb
left a comment
There was a problem hiding this comment.
👍🏼 auto deploy done, you are all good to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link