Conversation
pakb
left a comment
There was a problem hiding this comment.
As it doubles down on the text present on desktop, we could get rid of this text oustide of the search bar to gain some screen space. What's your take on that?
|
OK, for me. |
|
Might be a bit hard to achieve, but would be great if the search bar was centered vertically. And the TESTSITE warning placed underneath, after having centered the searchbar. |
13a1399 to
fc034cc
Compare
|
Looks like it centered now. No idea why, though. |
pakb
left a comment
There was a problem hiding this comment.
As I've used some bootstrap Flexbox magic to center all of this, it should be easier for you yes 😉
|
|
||
| <style lang="scss" scoped> | ||
| @import 'src/scss/variables'; | ||
|
|
||
| .search-bar { | ||
| position: absolute; | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| </style> |
There was a problem hiding this comment.
I'm not sure this is necessary, as the search bar is already centered by its parent (by HeaderWithSearchBar)
| // On desktop we limit hte maximum size of the search bar just | ||
| // to have a better look and feel. | ||
| max-width: 800px; | ||
| position: relative; |
There was a problem hiding this comment.
this too might be unnecessarry
d995039 to
581c2ec
Compare
Test link