Skip to content

BGDIINF_SB-2784 : fix Swiss flag position on smaller devices#375

Merged
pakb merged 3 commits intodevelopfrom
bug_BGDIINF_SB-2784_responsive_swiss_flag
Feb 16, 2023
Merged

BGDIINF_SB-2784 : fix Swiss flag position on smaller devices#375
pakb merged 3 commits intodevelopfrom
bug_BGDIINF_SB-2784_responsive_swiss_flag

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Feb 16, 2023

Wrap Swiss flag in div to better center it, this way its position centered in the space it is given

replaces #374

Test link

Wrap Swiss flag in div to better center it, this way its position centered in the space it is given
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon is not fully horizontally centered, the search bar adds a margin on the left which make the icon not in the center. Sorry I'm a bit picky 😉

in order to enable the content of the header to be vertically centered by the flexbox.
Otherwise, as it was also present in the same container as the search bar, the height of the disclaimer was taken into account when placing the search bar input at the vertical center of the header.

This then covers what was intended for the ticket BGDIINF_SB-2259
@pakb
Copy link
Contributor Author

pakb commented Feb 16, 2023

So I had some issue placing them correctly, with the dev site warning in the mix. So I resorted to moving this disclaimer elsewhere, a bit more prominent too, and adapted the menu height in the process.
In the end, every part of the header is now vertically centered, has no padding (or the same on each sides), meaning it should be more balanced 😉

@pakb pakb requested a review from ltshb February 16, 2023 12:22
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new test site disclaimer very good idea.

Just one more minor issue:
image
The menu button on mobile when not on focus is dark grey and don't have any spaces between search bar

@pakb
Copy link
Contributor Author

pakb commented Feb 16, 2023

mmh... a little left margin for this button could be good, yes

@pakb pakb requested a review from ltshb February 16, 2023 13:00
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pakb pakb merged commit 5025229 into develop Feb 16, 2023
@pakb pakb deleted the bug_BGDIINF_SB-2784_responsive_swiss_flag branch February 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants