BGDIINF_SB-2784 : fix Swiss flag position on smaller devices#375
Merged
BGDIINF_SB-2784 : fix Swiss flag position on smaller devices#375
Conversation
Wrap Swiss flag in div to better center it, this way its position centered in the space it is given
ltshb
reviewed
Feb 16, 2023
Contributor
ltshb
left a comment
There was a problem hiding this comment.
The icon is not fully horizontally centered, the search bar adds a margin on the left which make the icon not in the center. Sorry I'm a bit picky 😉
in order to enable the content of the header to be vertically centered by the flexbox. Otherwise, as it was also present in the same container as the search bar, the height of the disclaimer was taken into account when placing the search bar input at the vertical center of the header. This then covers what was intended for the ticket BGDIINF_SB-2259
Contributor
Author
|
So I had some issue placing them correctly, with the dev site warning in the mix. So I resorted to moving this disclaimer elsewhere, a bit more prominent too, and adapted the menu height in the process. |
ltshb
reviewed
Feb 16, 2023
Contributor
Author
|
mmh... a little left margin for this button could be good, yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Wrap Swiss flag in div to better center it, this way its position centered in the space it is given
replaces #374
Test link