Skip to content

Fix Swiss flag size on smaller devices#374

Closed
pakb wants to merge 2 commits intodevelopfrom
bug_fix_swissflag_size_on_mobile
Closed

Fix Swiss flag size on smaller devices#374
pakb wants to merge 2 commits intodevelopfrom
bug_fix_swissflag_size_on_mobile

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Feb 15, 2023

the flag was shrinking on smaller devices, when the menu is also smaller, not covering the full extent of the space it was given.

Test link

@pakb pakb requested review from jedef and ltshb February 15, 2023 13:27
@github-actions github-actions bot added the bug label Feb 15, 2023
the flag was downscaled on smaller devices, when the menu is also smaller, not covering the full extent of the space it was given.
@pakb pakb force-pushed the bug_fix_swissflag_size_on_mobile branch from c840b7a to d048b6f Compare February 15, 2023 14:17
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found the flag then too big on mobile. On old viewer it was also shrink.
For my taste I would leave it the same size, but it could be aligned with the search bar, aka centered vertically.

This way it is a bit smaller on mobile, but keep its position centered in the space it is given
@pakb
Copy link
Contributor Author

pakb commented Feb 16, 2023

replaced by #375

@pakb pakb closed this Feb 16, 2023
@pakb pakb deleted the bug_fix_swissflag_size_on_mobile branch February 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants