BGDIINF_SB-2793: leave menu open when searching#379
Merged
Conversation
pakb
approved these changes
Feb 21, 2023
| :class="{ | ||
| 'desktop-mode': isDesktopMode, | ||
| 'desktop-menu-closed': isDesktopMode && !showMenu, | ||
| 'desktop-menu-closed': isDesktopMode && !isMenuShown, |
Contributor
There was a problem hiding this comment.
Don't know if isMenuShown will ever be false on desktop (yet, as no fullscreen support on desktop implemented for now)
In desktop mode, do not hide the menu anymore when showing search results, but still do that in phone mode.
To make both the menu and the search results visible at the same time, above the size lg, the search bar starts after the menu tray so that the search results do not overlap with the menu.
717a2db to
c6ca810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link