Conversation
PB-364: Add parser for OGC WMS XML response for GetFeatureInfo.
PB-742: Do not decodeURI twice.
The link for "more informations" about the mapviewer now directs people to the base page on the 'News' section. If we ever have a CMS overhaul, we'll see where this link should go. Also included : translations changes that are yet to be merged.
On language change, the background layers weren't properly updated so that the reactivity propagated through to the UI, thus the link to the source was in the wrong language.
The background layer's attributes didn't update when the language was changed. This was because we copied the background layer around for setting the current one. Refactored the code so that we only set the ID of the layer and the actual data is being served through a getter.
PB-912 Fix language of background layer attribution
Issue : Supporting http resources with the mapviewer is being rolled out by late January at the latest. We need to inform people still using them to make the change Fix : We add a feedback warning specifically saying that there are resources in http, and that the user should change that. remove excess log
PB-827: Add warning when using http resources
Update libs to latest
Issue : when modifying the URL directly, users received no feedback about what they did wrong when making mistakes, especially on a productive environment where most logs are deactivated. Fix : we now give a feedback for every parameter that is wrongfully filled. We also added some extra cases for the layers, where we want to give a feedback on each individual layer, and for the time slider when everything is in order, but there are no layers supporting it.
- Added a way to handle external layers in the acceptedValues for layers, sending an error feedback when users try to add an external layer which doesn't have a scheme - Small correction to the backgroundLayer acceptedValues, where we were not looking at the right place for information, causing the background layer to be void as soon as we tried to reload. small adjustments
- We now return an object containing a validation Boolean, errors and warnings to be pushed - We need to implement the 'addErrors' and 'addWarnings' methods - Simplification of the layers validation : we no longer give the full set of parameters, since the only thing that we check is the layer id / base url
- Added the store methods to handle the changes - Also modified the warnings queue to follow the same logic as the error queue
…e rather than being a method of the AbstractParameterClass, as this couldn't be used in the basic storesync parameters
- we removed some artifacts from when error queues functions were a part of abstractParamConfig class
… when trying to populate the store
- the timeslider, when reloading, would handle the parameter as a string, and would fail the Number.isInteger test. Also, when activating the timeslider through the button, it would trigger a URL change, and detect some parameters (crosshair and camera, for example) as being present but undefined, causing errors to appear. small update : ensuring we compare sr as a number small update: featureInfo is case insensitive
- Removed double ternary operator in LayerParamConfig for easier reading - Removed dirty ssssssnake case in errorQueues - Comments should be in better places, and/or explaining some not so evident parameters validations
Issue : the validation returned a falsy value when the layer parameter was set to an empty string. Also, setting the layer parameter to en empty string would give you the store content, as it was ignoring the parameter in those case Fix : add a check for an empty string at the very beginning of the layer param validation, and added a check to ensure we can populate the layers with an empty string removing some snakes
…-all-url-parameters PB-984: add error feedback for all URL parameters
…ion in modify interaction.
PB-199: add new point on an existing line
ltshb
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link