PB-827: Add warning when using http resources#1080
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-827-add-warning-http
|
| Run status |
|
| Run duration | 05m 19s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
211
|
| View all changes introduced in this branch ↗︎ | |
3902b8d to
229bd71
Compare
229bd71 to
3870766
Compare
pakb
approved these changes
Oct 1, 2024
Issue : Supporting http resources with the mapviewer is being rolled out by late January at the latest. We need to inform people still using them to make the change Fix : We add a feedback warning specifically saying that there are resources in http, and that the user should change that. remove excess log
3870766 to
f94f428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : Supporting http resources with the mapviewer is being rolled out by late January at the latest. We need to inform people still using them to make the change
Fix : We add a feedback warning specifically saying that there are resources in http, and that the user should change that.
still a draft for now : I need to add the links and ensure translation is correct
Test link