PB-364: Add parser for OGC WMS XML response for GetFeatureInfo.#1074
Merged
ismailsunni merged 1 commit intodevelopfrom Sep 30, 2024
Merged
PB-364: Add parser for OGC WMS XML response for GetFeatureInfo.#1074ismailsunni merged 1 commit intodevelopfrom
ismailsunni merged 1 commit intodevelopfrom
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
pb-364-plain-text-parsing
|
| Run status |
|
| Run duration | 04m 26s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
ltkum
approved these changes
Sep 24, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
It seems to be working, so we can go ahead with this. I would still add the warning queue dispatch, so we still tell the users we're not parsing plaintext.
| break | ||
| case PLAIN_TEXT_TYPE: | ||
| // TODO : implement plain text parsing | ||
| log.error('Plain text parsing not yet implemented') |
Contributor
There was a problem hiding this comment.
if it's not too much work, I would add a small addWarning dispatch here, to let the user know that if he imports a plain text document, we won't parse it.
Contributor
Author
There was a problem hiding this comment.
It seems not straight forward to add. I can't import the store in the api directory. I will skip it for now, and treat like other 'error' in this file with log.error only.
45f3186 to
12a03bb
Compare
12a03bb to
517f38e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the ticket is about parsing plain text response from GetFeatureInfo request. Unfortunately, there is no standard on how to do it. For example these two requests have completely different format if we request as plain/text:
In this case, I tried to parse other possible format available in the problematic WMS in the ticket, which is a
application/vnd.ogc.wms_xml. I checked in other WMS in the ticket also have this output format and works well.Result
Test link with sample data
Test link