Skip to content

PB-900: Add no shared icon and text#1060

Merged
sommerfe merged 2 commits intodevelopfrom
feat-pb-900-local-kml-cannot-share
Sep 30, 2024
Merged

PB-900: Add no shared icon and text#1060
sommerfe merged 2 commits intodevelopfrom
feat-pb-900-local-kml-cannot-share

Conversation

@sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Sep 9, 2024

@cypress
Copy link

cypress bot commented Sep 9, 2024

web-mapviewer    Run #3435

Run Properties:  status check passed Passed #3435  •  git commit d8757d41a1: PB-900 : adding translation for new local file warning
Project web-mapviewer
Branch Review feat-pb-900-local-kml-cannot-share
Run status status check passed Passed #3435
Run duration 05m 42s
Commit git commit d8757d41a1: PB-900 : adding translation for new local file warning
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch 3 times, most recently from 4b0d0bb to 8cea333 Compare September 11, 2024 10:20
@sommerfe
Copy link
Contributor Author

These are currently the different options
Screenshot from 2024-09-11 13-10-14

@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch 5 times, most recently from c819473 to 6a9fade Compare September 17, 2024 09:02
@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch 4 times, most recently from 00903aa to 0a829b7 Compare September 23, 2024 14:08
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to hit the "re-request review" button on GitHub, so that I know I should have a look at the code 😉
(or add me the first time to the reviewers)

@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch from 0a829b7 to 8687964 Compare September 30, 2024 08:16
@sommerfe sommerfe requested a review from pakb September 30, 2024 08:24
@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch 4 times, most recently from ef986d7 to b413fe4 Compare September 30, 2024 11:06
@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch from b413fe4 to 8170574 Compare September 30, 2024 11:07
@sommerfe sommerfe force-pushed the feat-pb-900-local-kml-cannot-share branch from 8170574 to d8757d4 Compare September 30, 2024 11:38
@sommerfe sommerfe merged commit 8441d7c into develop Sep 30, 2024
@sommerfe sommerfe deleted the feat-pb-900-local-kml-cannot-share branch September 30, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants