PB-1031: link for more informations changed#1077
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1031-change-information-link
|
| Run status |
|
| Run duration | 04m 00s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
ismailsunni
approved these changes
Sep 30, 2024
Contributor
ismailsunni
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge it my comment is not valid :)
| "close_menu": "Serrar menu", | ||
| "cms_link_button_title": "Dapli infurmaziuns", | ||
| "cms_link_button_url": "https://www.geo.admin.ch/rm/chartas/chartas.html", | ||
| "cms_link_button_url": "https://www.geo.admin.ch/de/#News", |
Contributor
There was a problem hiding this comment.
Why not https://www.geo.admin.ch/rm/#News ?
Contributor
Author
There was a problem hiding this comment.
because the official website doesn't do that language, and by default when Rhumantsch is not available, we give them the german version
fd94495 to
8818311
Compare
The link for "more informations" about the mapviewer now directs people to the base page on the 'News' section. If we ever have a CMS overhaul, we'll see where this link should go. Also included : translations changes that are yet to be merged.
8818311 to
3d01fab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link for "more informations" about the mapviewer now directs people to the base page on the 'News' section. If we ever have a CMS overhaul, we'll see where this link should go.
Also included : translations changes that are yet to be merged.
Test link