Skip to content

Added Interval Python interface#449

Merged
ahcorde merged 8 commits intoign-math6from
ahcorde/python/interval
Jul 11, 2022
Merged

Added Interval Python interface#449
ahcorde merged 8 commits intoign-math6from
ahcorde/python/interval

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Jul 4, 2022

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

🎉 New feature

Closes #391

Depends on #448

Summary

Added Interval Python interface

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

hidmic and others added 7 commits July 4, 2022 09:51
@hidmic @ahcorde
Add Interval class (#388)
f01c06f 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Add Region3 class (#390)
1b84ea1 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @chapulina @ahcorde
Add Polynomial3 class (#393)
519e794 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@hidmic @chapulina @ahcorde
Add AdditivelySeparableScalarField3 class (#397)
6a6cbd4 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@hidmic @ahcorde
Fix unsafe globals in Interval and Region3 (#396)
17e8eff 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Add PiecewiseScalarField3 class (#398)
5bd8576 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@ahcorde
Added IntervalPython interface
43188b6 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Jul 4, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2022 •
edited
Loading

Codecov Report

Merging #449 (76e71a7) into ign-math6 (0b278c9) will not change coverage.
The diff coverage is n/a.

❗ Current head 76e71a7 differs from pull request most recent head e64569e. Consider uploading reports for the commit e64569e to get more accurate results

@@            Coverage Diff             @@
##           ign-math6     #449   +/-   ##
==========================================
  Coverage      99.68%   99.68%           
==========================================
  Files             73       73           
  Lines           6901     6901           
==========================================
  Hits            6879     6879           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b278c9...e64569e. Read the comment docs.

This was referenced Jul 4, 2022
Merged
Merged
@ahcorde ahcorde added 🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress labels Jul 5, 2022
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jul 5, 2022
Base automatically changed from ahcorde/6/backport_388 to ign-math6 July 8, 2022 17:00
@ahcorde ahcorde merged commit 534f73a into ign-math6 Jul 11, 2022
@ahcorde ahcorde deleted the ahcorde/python/interval branch July 11, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

@ahcorde ahcorde

Labels

🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress scripting Scripting interfaces to Ignition

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Interval class Python wrapper

5 participants

@ahcorde @adityapande-1995 @chapulina @osrf-triage @hidmic