Add PiecewiseScalarField3 class#398
Merged
chapulina merged 7 commits intogazebosim:mainfrom Apr 1, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 69 70 +1
Lines 6353 6406 +53
=======================================
+ Hits 6336 6389 +53
Misses 17 17
Continue to review full report at Codecov.
|
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
d17cd9b to
ec218a4
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
chapulina
reviewed
Mar 30, 2022
Contributor
chapulina
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments
8 tasks
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
chapulina
approved these changes
Apr 1, 2022
Contributor
chapulina
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments!
ahcorde
pushed a commit
that referenced
this pull request
Jul 4, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
chapulina
pushed a commit
that referenced
this pull request
Jul 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Split from #387. This PR introduces a
PiecewiseScalarField3class to represent a scalar field in R^3 defined on a per region basis.Depends on #397 for testing.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.