Skip to content

Add AdditivelySeparableScalarField3 class#397

Merged
chapulina merged 5 commits intogazebosim:mainfrom
hidmic:add-additively-separable-scalar-field3-class
Mar 29, 2022
Merged

Add AdditivelySeparableScalarField3 class#397
chapulina merged 5 commits intogazebosim:mainfrom
hidmic:add-additively-separable-scalar-field3-class

Conversation

@hidmic
Copy link
Copy Markdown
Contributor

@hidmic hidmic commented Mar 25, 2022 •
edited
Loading

🎉 New feature

Summary

Split from #387. This PR introduces an AdditivelySeparableScalarField3 class, a particularly simple kind of scalar field in R^3.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@hidmic hidmic added the MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv label Mar 25, 2022
@hidmic hidmic requested a review from chapulina March 25, 2022 20:06
@hidmic hidmic requested a review from scpeters as a code owner March 25, 2022 20:06
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 25, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #397 (2366d2c) into main (71b6db2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          68       69    +1     
  Lines        6314     6353   +39     
=======================================
+ Hits         6297     6336   +39     
  Misses         17       17
Impacted Files Coverage Δ
...e/ignition/math/AdditivelySeparableScalarField3.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b6db2...2366d2c. Read the comment docs.

@hidmic hidmic mentioned this pull request Mar 25, 2022
Merged
7 tasks
@hidmic
Add AdditivelySeparableScalarField3 class
2f69ada 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the add-additively-separable-scalar-field3-class branch from 21da2d2 to 2f69ada Compare March 28, 2022 11:11
chapulina
chapulina approved these changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. I just have minor stylistic comments. Feel free to merge once those are addressed.

hidmic and others added 3 commits March 29, 2022 17:50
@hidmic
Use camelBack style for variables
ff97d18 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Document AdditivelySeparableScalarField3 template params
b27d5f0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@chapulina
Added missing doxygen
2366d2c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) March 29, 2022 22:48
@chapulina chapulina merged commit dcde2c0 into gazebosim:main Mar 29, 2022
@ahcorde ahcorde mentioned this pull request Mar 30, 2022
Open
This was referenced Mar 30, 2022
Closed
Closed
ahcorde pushed a commit that referenced this pull request Jul 4, 2022
@hidmic @chapulina @ahcorde
Add AdditivelySeparableScalarField3 class (#397)
6a6cbd4 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Jul 8, 2022
@hidmic @chapulina
Add AdditivelySeparableScalarField3 class (#397)
603accd 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@ahcorde ahcorde mentioned this pull request Jul 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌱 garden Ignition Garden MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hidmic @chapulina @j-rivero @osrf-triage