Fix unsafe globals in Interval and Region3#396
Merged
chapulina merged 3 commits intogazebosim:mainfrom Mar 30, 2022
Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 69 69
Lines 6353 6353
=======================================
Hits 6336 6336
Misses 17 17
Continue to review full report at Codecov.
|
Member
|
it seems right to me, but I think @azeey understands this issue better than me. I think the right way to test this is with asan using gazebosim/gz-cmake#210, but I haven't had a chance to do so. I think it's fine to merge without my approval. Once we get CI with sanitizers, we'll know for sure :) |
Contributor
|
Sounds reasonable, we can revisit when the sanitizers are running in CI, if needed |
ahcorde
pushed a commit
that referenced
this pull request
Jul 4, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
chapulina
pushed a commit
that referenced
this pull request
Jul 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Relates to #269.
Summary
This PR fixes a potential global initialization order issue introduced in #388 and #390 by making all
IntervalandRegion3construction formsconstexpr.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.