Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
Author
|
@chapulina PTAL! |
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 66 67 +1
Lines 6189 6219 +30
=======================================
+ Hits 6172 6202 +30
Misses 17 17
Continue to review full report at Codecov.
|
chapulina
suggested changes
Mar 21, 2022
Contributor
chapulina
left a comment
There was a problem hiding this comment.
The general idea looks good to me. I have minor comments about documentation and notation, and the only blocker at the moment is CI.
- Avoid chaining global references - Drop visibility attributes - Update docblock Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
b36e834 to
d7c74a5
Compare
chapulina
approved these changes
Mar 21, 2022
This was referenced Mar 25, 2022
ahcorde
pushed a commit
that referenced
this pull request
Jul 4, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
chapulina
pushed a commit
that referenced
this pull request
Jul 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Split from #387. This PR introduces a Region3 class to represent regions in R^3 space. To do this, it builds on top of the Interval class introduced by #388.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.