Dispose TextEditingController in IndexedStack example by BilalRehman08 · Pull Request #186375 · flutter/flutter

BilalRehman08 · 2026-05-11T22:04:27Z

Description

The _IndexedStackExampleState class in the IndexedStack API example creates a TextEditingController but never disposes it, causing a resource leak.

Added a dispose() override that calls fieldText.dispose() before super.dispose().

@override
void dispose() {
  fieldText.dispose();
  super.dispose();
}

Fixes #186324

Tests

Existing tests in examples/api/test/widgets/basic/indexed_stack.0_test.dart cover the example. No new tests needed for a dispose fix.

flutter-dashboard · 2026-05-11T22:04:32Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request adds a dispose method to the _IndexedStackExampleState class in examples/api/lib/widgets/basic/indexed_stack.0.dart. This implementation ensures that the TextEditingController is properly disposed of when the widget is removed from the tree, preventing potential memory leaks. I have no feedback to provide.

The _IndexedStackExampleState class created a TextEditingController but never disposed it, causing a resource leak. Added dispose() to properly clean up the controller when the widget is removed from the tree. Fixes flutter#186324

Renzo-Olivares

LGTM, thank you for the contribution! You will need to request a test-exemption on our flutter-hackers discord.

chunhtai

LGTM

QuncCccccc

LGTM! Thanks!

Piinks

LGTM thank you!

flutter/flutter@1ceffd1...3598686 2026-05-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 bdero@google.com [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 srawlins@google.com [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186602) 2026-05-16 chris@bracken.jp [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 30870216+gaaclarke@users.noreply.github.com Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 mdebbar@google.com [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 alex.medinsh@gmail.com Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 chris@bracken.jp [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 jason-simmons@users.noreply.github.com Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 155553833+MatejLNCD@users.noreply.github.com Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 1063596+reidbaker@users.noreply.github.com Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 engine-flutter-autoroll@skia.org Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 53112208+BilalRehman08@users.noreply.github.com Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 34465683+rkishan516@users.noreply.github.com refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11724) flutter/flutter@1ceffd1...3598686 2026-05-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 bdero@google.com [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 srawlins@google.com [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186602) 2026-05-16 chris@bracken.jp [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 30870216+gaaclarke@users.noreply.github.com Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 mdebbar@google.com [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 alex.medinsh@gmail.com Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 chris@bracken.jp [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 jason-simmons@users.noreply.github.com Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 155553833+MatejLNCD@users.noreply.github.com Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 1063596+reidbaker@users.noreply.github.com Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 engine-flutter-autoroll@skia.org Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 53112208+BilalRehman08@users.noreply.github.com Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 34465683+rkishan516@users.noreply.github.com refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 11, 2026

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Dispose TextEditingController in IndexedStack example

34e70f7

The _IndexedStackExampleState class created a TextEditingController but never disposed it, causing a resource leak. Added dispose() to properly clean up the controller when the widget is removed from the tree. Fixes flutter#186324

BilalRehman08 force-pushed the fix/indexed-stack-dispose-controller branch from 90202a9 to 34e70f7 Compare May 11, 2026 22:07

Piinks requested a review from Renzo-Olivares May 12, 2026 22:16

Renzo-Olivares approved these changes May 12, 2026

View reviewed changes

Renzo-Olivares added the CICD Run CI/CD label May 12, 2026

victorsanni approved these changes May 12, 2026

View reviewed changes

chunhtai approved these changes May 12, 2026

View reviewed changes

QuncCccccc approved these changes May 12, 2026

View reviewed changes

Piinks approved these changes May 12, 2026

View reviewed changes

AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2026

auto-submit Bot added this pull request to the merge queue May 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 15, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2026

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2026

auto-submit Bot added this pull request to the merge queue May 15, 2026

Merged via the queue into flutter:master with commit 488bdad May 16, 2026
68 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dispose TextEditingController in IndexedStack example#186375

Dispose TextEditingController in IndexedStack example#186375
auto-submit[bot] merged 1 commit into
flutter:masterfrom
BilalRehman08:fix/indexed-stack-dispose-controller

BilalRehman08 commented May 11, 2026

Uh oh!

flutter-dashboard Bot commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Renzo-Olivares left a comment •

edited

Loading

Uh oh!

chunhtai left a comment

Uh oh!

QuncCccccc left a comment

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

BilalRehman08 commented May 11, 2026

Description

Tests

Uh oh!

flutter-dashboard Bot commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Renzo-Olivares left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Renzo-Olivares left a comment •

edited

Loading