Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1ceffd11a471
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3598686e42e3
Choose a head ref
  • 17 commits
  • 61 files changed
  • 17 contributors

Commits on May 15, 2026

  1. refactor: update filename for sliver semantic widget (#185917)

    This PR is follow up to
    #185567 (comment)
    conversation where we want to properly name and split test files.
    
    part of: #177415
    
    # Current Status
    
    - Renamed `sliversemantics_test.dart` to
    `sliver_semantics_widget_test.dart`
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ---------
    
    Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev>
    rkishan516 and Renzo-Olivares authored May 15, 2026
    Configuration menu
    Copy the full SHA
    3589c3b View commit details
    Browse the repository at this point in the history
  2. Dispose TextEditingController in IndexedStack example (#186375)

    ## Description
    
    The `_IndexedStackExampleState` class in the `IndexedStack` API example
    creates a `TextEditingController` but never disposes it, causing a
    resource leak.
    
    Added a `dispose()` override that calls `fieldText.dispose()` before
    `super.dispose()`.
    
    ```dart
    @OverRide
    void dispose() {
      fieldText.dispose();
      super.dispose();
    }
    ```
    
    Fixes #186324
    
    ## Tests
    
    Existing tests in
    `examples/api/test/widgets/basic/indexed_stack.0_test.dart` cover the
    example. No new tests needed for a dispose fix.
    BilalRehman08 authored May 15, 2026
    Configuration menu
    Copy the full SHA
    488bdad View commit details
    Browse the repository at this point in the history
  3. Roll Packages from 2ec2236264c2 to 32c84d652e54 (3 revisions) (#186583)

    flutter/packages@2ec2236...32c84d6
    
    2026-05-15 engine-flutter-autoroll@skia.org Manual roll Flutter from
    23f6f58 to 0541913 (28 revisions) (flutter/packages#11713)
    2026-05-15 s_gilligan@live.co.uk [video_player] Fix washed-out HDR video
    playback on iOS (flutter/packages#11569)
    2026-05-14 engine-flutter-autoroll@skia.org Roll Flutter from
    707dbc0 to 23f6f58 (149 revisions) (flutter/packages#11700)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC flutter-ecosystem@google.com on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 15, 2026
    Configuration menu
    Copy the full SHA
    a911186 View commit details
    Browse the repository at this point in the history
  4. Update dart_skills_lint dependency to e449787 and optimize skills val…

    …idation test (#186528)
    
    Updates the pinned Git reference for `dart_skills_lint` in
    `dev/tools/pubspec.yaml` to commit hash
    `e4497873950727ee781fa411c1a2f624b1ec50c6` (version `0.3.0`).
    
    Introduces a standalone `dev/tools/dart_skills_lint.yaml` configuration
    file and refactors `dev/tools/test/validate_skills_test.dart` to
    dynamically load and enforce this centralized configuration.
    All default built-in rules are explicitly disabled within the secondary
    backticks validation test block for performance.
    References flutter/skills#85
    
    ## Pre-launch Checklist
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    - [ ] 
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    reidbaker authored May 15, 2026
    Configuration menu
    Copy the full SHA
    1c04fd1 View commit details
    Browse the repository at this point in the history
  5. Fix web-server hot restart/reload not applying changes for entrypoint…

    …s outside lib (#183838)
    
    Fix `toMultiRootPath` producing URIs with empty authority, breaking hot
    restart for entrypoints outside `lib/`
    
    When running `flutter run -d web-server` with an entrypoint outside
    `lib/` (e.g. `integration_test/main.dart`), hot restart triggers but
    code changes are never reflected. The app keeps showing stale code.
    
    ### Root cause
    
    The hot restart pipeline has a URI format mismatch between two code
    paths:
    
    1. **`_generateEntrypoint`** (in `resident_web_runner.dart`) registers
    the entrypoint with the compiler using the `Uri` constructor:
       ```dart
       Uri(scheme: 'org-dartlang-app', path: '/main.dart')
    // produces: org-dartlang-app:/main.dart (no authority,
    hasAuthority=false)
       ```
    
    2. **`toMultiRootPath`** (in `compile.dart`) converts invalidated
    `file:` URIs back to `org-dartlang-app:` URIs during recompilation using
    string concatenation:
       ```dart
       '$scheme://${filePath.substring(fileSystemRoot.length)}'
    // produces: org-dartlang-app:///main.dart (empty authority,
    hasAuthority=true)
       ```
    
    These two URIs are **not equal**, so the frontend server doesn't find a
    matching library to invalidate and returns cached (stale) output.
    
    This only affects entrypoints outside `lib/` because files under `lib/`
    are converted to `package:` URIs via `packageConfig.toPackageUri()`,
    bypassing `toMultiRootPath` entirely.
    
    ### Fix
    
    Replace the string concatenation in `toMultiRootPath` with the `Uri`
    constructor — the same approach used by `_generateEntrypoint`:
    
    ```dart
    // Before (string concatenation — introduces empty authority):
    return '$scheme://${filePath.substring(fileSystemRoot.length)}';
    
    // After (Uri constructor — no authority):
    return Uri(scheme: scheme, path: filePath.substring(fileSystemRoot.length)).toString();
    ```
    
    Fixes #175318
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    MatejLNCD authored May 15, 2026
    Configuration menu
    Copy the full SHA
    405e037 View commit details
    Browse the repository at this point in the history
  6. Increase the run time of text field integration tests to 10 seconds (#…

    …186475)
    
    These tests have been flaky because they sometimes end before generating
    the number of frames expected by the performance test framework.
    
    See #185734
    jason-simmons authored May 15, 2026
    Configuration menu
    Copy the full SHA
    72957a6 View commit details
    Browse the repository at this point in the history
  7. [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayL…

    …ink (#186456)
    
    Adds doc comments for FlutterVSyncClient and FlutterDisplayLink as well
    as implementation notes in the `-[FlutterDisplayLink onDisplayLink:]`
    callback.
    
    No test changes since this is a documentation-only patch.
    
    Related PRs:
    * #186166
    * #186266
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    cbracken authored May 15, 2026
    Configuration menu
    Copy the full SHA
    aa0ab60 View commit details
    Browse the repository at this point in the history
  8. Display the team ID and name when selecting a signing certificate (#1…

    …84665)
    
    Before
    
    `[1] iPhone Developer: Profile 3 (3333CCCC33)`
    
    After
    
    `[1] iPhone Developer: Profile 3 (3333CCCC33) | Team: 4444DDDD44 My
    Team`
    
    Where `4444DDDD44 My Team` corresponds to the team id and team name from
    Apple Developer account.
    
    Fixes #184664
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    Co-authored-by: Elijah Okoroh <okorohelijah@google.com>
    alex-medinsh and okorohelijah authored May 15, 2026
    Configuration menu
    Copy the full SHA
    a76d1f0 View commit details
    Browse the repository at this point in the history
  9. [web] Fix several WebParagraph bugs (#186403)

    - Any zoom level other than 100% was throwing assertions.
    - In some cases, one paragraph was bleeding into other paragraphs.
    - Paragraph image cache was stale in many cases.
    - Paragraph image cache was leaking after the paragraph is disposed.
    - `maxIntrinsicWidth` was calculated incorrectly.
    - Paint canvas was not sized correctly.
    - Few methods weren't used anywhere.
    mdebbar authored May 15, 2026
    Configuration menu
    Copy the full SHA
    c68d6ed View commit details
    Browse the repository at this point in the history
  10. Removes bringup from passing macos/sdf tests (#186527)

    These tests have been passing as green for a long time now.
    - Mac hello_world_impeller_macos_sdfs
    - Mac_arm64 wide_gamut_macos
    - Mac_ios hello_world_impeller_ios_sdfs
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    gaaclarke authored May 15, 2026
    Configuration menu
    Copy the full SHA
    4e6f99c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2026

  1. Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk…

    …... (#186599)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC codefu@google.com,zra@google.com on the revert to ensure that
    a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 16, 2026
    Configuration menu
    Copy the full SHA
    ccc6f33 View commit details
    Browse the repository at this point in the history
  2. [gn] Fix typo in comment (#186549)

    Correct "Runs true" to "Returns true", "python" to "Python", and "I.e."
    to "i.e.".
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    cbracken authored May 16, 2026
    Configuration menu
    Copy the full SHA
    bcaa6e0 View commit details
    Browse the repository at this point in the history
  3. Roll pub packages (#186602)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored May 16, 2026
    Configuration menu
    Copy the full SHA
    c5526e9 View commit details
    Browse the repository at this point in the history
  4. refactor: Remove material imports from Widget tests (#185078)

    This PR removes Material imports from:
    
    - default_text_editing_shortcuts_test.dart
    - framework_test.dart
    - scrollable_in_overlay_test.dart
    
    Also moved `TestRadio` & `TestSlider` widgets to their respective
    separate files `radio_tester.dart` & `slider_tester.dart`
    
    part of: #177415 
    dependent on #184798 
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ---------
    
    Co-authored-by: rkishan516 <rkishan516@gmail.com>
    master-wayne7 and rkishan516 authored May 16, 2026
    Configuration menu
    Copy the full SHA
    a8c3b09 View commit details
    Browse the repository at this point in the history
  5. [widgets] Use super parameters in missed spots (#186198)

    Work towards dart-lang/sdk#59226
    
    The analyzer will start reporting cases where a super parameter could be
    used, and the type of the supar parameter is tightened in the subclass
    constructor. This is still a perfectly valid super parameter use case.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    srawlins authored May 16, 2026
    Configuration menu
    Copy the full SHA
    467c55f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2026

  1. [Impeller] Canonicalize uniform block instance names for the GL backe…

    …nds (#186394)
    
    Fixes #186393.
    
    On pre-`#version 140` GL targets (`kOpenGLES`, `kOpenGLDesktop`),
    SPIRV-Cross lowers `uniform Block { ... } instance;` to `struct Block {
    ... }; uniform Block instance;` and the driver reports members as
    `instance.member`. `BufferBindingsGLES` looks them up by the **block**
    name modulo a case- and underscore-insensitive match, so a
    non-conforming instance name (e.g. `uniform ToonInfo { ... } toon;`)
    silently binds every member to GL location `-1`.
    
    This PR makes `impellerc` rewrite non-conforming instance names to
    `_<BlockName>` (which reduces to the block name under the same fold)
    before emitting GLSL for those targets. Conforming instance names
    (`XInfo` / `x_info`) are left alone; shader reflection (keyed on the
    block name) is untouched; no shader bundle / runtime stage format
    change. Vulkan and Metal are unaffected (they bind by descriptor index).
    
    Verified on a Pixel 10 Pro: the broken shader from the linked issue now
    renders identically to Vulkan / Metal. New compiler unit test
    (`UniformBlockInstanceNameCanonicalizedForGL`) compiles `mat2_test.frag`
    (`uniform Params { ... } uParams;`) for the GL targets and asserts the
    emitted source uses `_Params.` rather than `uParams.`.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    This change was developed with AI assistance; I have reviewed and take
    responsibility for it.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    bdero authored May 17, 2026
    Configuration menu
    Copy the full SHA
    b70baff View commit details
    Browse the repository at this point in the history
  2. Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3…

    …... (#186636)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC codefu@google.com,zra@google.com on the revert to ensure that
    a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 17, 2026
    Configuration menu
    Copy the full SHA
    3598686 View commit details
    Browse the repository at this point in the history
Loading