refactor: Remove material imports from Widget tests by master-wayne7 · Pull Request #185078 · flutter/flutter

master-wayne7 · 2026-04-15T12:04:25Z

This PR removes Material imports from:

default_text_editing_shortcuts_test.dart
framework_test.dart
scrollable_in_overlay_test.dart

Also moved TestRadio & TestSlider widgets to their respective separate files radio_tester.dart & slider_tester.dart

part of: #177415
dependent on #184798

Pre-launch Checklist

…ditable_text_scribe_test, page_route_builder_test, radio_group_test, semantics_debugger_test, range_maintaining_scroll_physics_test, two_dimensional_scroll_view_test, routes_test, text_selection_test, selectable_region_test and text_golden_test

gemini-code-assist

Code Review

This pull request refactors several widget tests to remove dependencies on the Material library, replacing Material widgets with custom test-specific implementations like TestCheckbox, TestRadio, and TestButton. It also updates the test infrastructure to use a custom TestWidgetsApp instead of MaterialApp. Feedback was provided regarding the use of instantaneous page changes in tests and a suggestion to improve the reusability of the newly introduced TestSlider widget.

rkishan516

Just few small changes

justinmc · 2026-04-15T22:00:23Z

Thanks for helping with the test decoupling effort! I'm going to focus on getting #184798 landed before I review this so that it's easier to see the specific changes done here. @master-wayne7 is the reason that you branched off of that PR because you needed TestCheckbox?

master-wayne7 · 2026-04-16T04:23:37Z

@master-wayne7 is the reason that you branched off of that PR because you needed TestCheckbox?

Yeah in semantics_role_checks_test.dart I needed TechCheckbox.

…ditable_text_scribe_test, page_route_builder_test, radio_group_test, semantics_debugger_test, range_maintaining_scroll_physics_test, two_dimensional_scroll_view_test, routes_test, text_selection_test, selectable_region_test and text_golden_test

…trols

…6/flutter into refactor/cross-imports-v2

…ss-imports-v2

master-wayne7 · 2026-04-27T11:07:13Z

@rkishan516 @justinmc I have updated PR with master branch, now it will only show my changes. You guys can now review it.

rkishan516 · 2026-04-27T13:40:26Z

+/// A minimal implementation of [RadioGroupRegistry] for widget tests.
+///
+/// Useful when testing [RawRadio] in isolation, outside of a [RadioGroup].
+class TestRegistry<T> extends RadioGroupRegistry<T> {


Are we using TestRegistry somewhere? If not then shouldn't we remove it?

Yes its used in radio_group_test.dart and radio_tester_test.dart

Nit: I suggest renaming it to TestRadioGroupRegistry. Now that it is a public test util I think it helps to be more explicit about the name.

rkishan516 · 2026-04-27T13:43:22Z

+
+/// A stateful wrapper that hosts a [RadioGroup] with a mutable [groupValue],
+/// making it easy to pump and interact with [TestRadio] buttons in tests.
+class _TestRadioGroup<T> extends StatefulWidget {


Could we have radio group tester like radio tester or maybe atleast we can move this to radio tester? Thoughts.

I'm happy either way. If we do make a radio_group_tester.dart we should also make a radio_group_tester_test.dart though.

I am creating a separate radio_group_tester.dart which will have this code. But we already have a radio_group_test.dart file which is also using TestRadioGroup so no additional testing file is required for this.

justinmc

I think the only real blockers I see is that _TestSlider and the restoration_scopes_moving changes should be removed. Thanks!

justinmc · 2026-04-27T21:49:35Z

+
+/// A stateful wrapper that hosts a [RadioGroup] with a mutable [groupValue],
+/// making it easy to pump and interact with [TestRadio] buttons in tests.
+class _TestRadioGroup<T> extends StatefulWidget {


I'm happy either way. If we do make a radio_group_tester.dart we should also make a radio_group_tester_test.dart though.

justinmc

LGTM 👍

rkishan516

LGTM

victorsanni · 2026-05-08T22:33:10Z

@@ -0,0 +1,35 @@
+// Copyright 2014 The Flutter Authors. All rights reserved.


There is no associated test file for this class?

Or do we not need a test here given widgets/radio_tester_test.dart already tests for mutable groupValue? And the widget has only a child property?

There was already a radio_droup_test.dart file, I have updated that to use the TestRadioGroup.

auto-submit · 2026-05-12T22:31:26Z

autosubmit label was removed for flutter/flutter/185078, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

…ss-imports-v2

master-wayne7 · 2026-05-13T04:31:08Z

Hey @Piinks , I have updated the branch with the latest changes.

flutter/flutter@1ceffd1...3598686 2026-05-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 bdero@google.com [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 srawlins@google.com [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186602) 2026-05-16 chris@bracken.jp [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 30870216+gaaclarke@users.noreply.github.com Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 mdebbar@google.com [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 alex.medinsh@gmail.com Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 chris@bracken.jp [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 jason-simmons@users.noreply.github.com Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 155553833+MatejLNCD@users.noreply.github.com Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 1063596+reidbaker@users.noreply.github.com Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 engine-flutter-autoroll@skia.org Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 53112208+BilalRehman08@users.noreply.github.com Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 34465683+rkishan516@users.noreply.github.com refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11724) flutter/flutter@1ceffd1...3598686 2026-05-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 bdero@google.com [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 srawlins@google.com [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186602) 2026-05-16 chris@bracken.jp [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 30870216+gaaclarke@users.noreply.github.com Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 mdebbar@google.com [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 alex.medinsh@gmail.com Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 chris@bracken.jp [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 jason-simmons@users.noreply.github.com Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 155553833+MatejLNCD@users.noreply.github.com Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 1063596+reidbaker@users.noreply.github.com Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 engine-flutter-autoroll@skia.org Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 53112208+BilalRehman08@users.noreply.github.com Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 34465683+rkishan516@users.noreply.github.com refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

rkishan516 and others added 2 commits April 11, 2026 04:31

Removed material imports from multiple files

adc295e

master-wayne7 mentioned this pull request Apr 15, 2026

(Test cross-imports) Don't import Material in tests for convenience #177415

Open

gemini-code-assist Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/framework_test.dart Outdated

Comment thread packages/flutter/test/widgets/semantics_debugger_test.dart Outdated

refactored code based on gemini github bot's review

dbcbc7c

rkishan516 reviewed Apr 15, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart Outdated

Comment thread packages/flutter/test/widgets/framework_test.dart Outdated

updated the colors to single channel

0650e61

master-wayne7 requested a review from rkishan516 April 16, 2026 06:22

justinmc added this to Test cross-imports Review Queue Apr 21, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Apr 21, 2026

justinmc self-requested a review April 21, 2026 22:25

rkishan516 and others added 7 commits April 24, 2026 12:06

fix: selectable region test with new _TestDraggableSelectionHandleCon…

7a68e25

…trols

test: changes based on feedback

434eb6a

test: update based on feedback

59859da

fix: update text golden with proper text style

4e79142

Merge branch 'simple-cross-imports-8' of https://github.com/rkishan51…

56fed30

…6/flutter into refactor/cross-imports-v2

Merge branch 'master' of github.com:flutter/flutter into refactor/cro…

02edc41

…ss-imports-v2

github-actions Bot removed the f: routes Navigator, Router, and related APIs. label Apr 27, 2026

removed files entries from check_tests_cross_imports

2d903e2

rkishan516 reviewed Apr 27, 2026

View reviewed changes

justinmc reviewed Apr 27, 2026

View reviewed changes

justinmc approved these changes May 5, 2026

View reviewed changes

justinmc added the CICD Run CI/CD label May 5, 2026

justinmc requested a review from victorsanni May 5, 2026 22:27

rkishan516 approved these changes May 6, 2026

View reviewed changes

victorsanni approved these changes May 8, 2026

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2026

Merge branch 'master' of github.com:flutter/flutter into refactor/cro…

b4d902c

…ss-imports-v2

github-actions Bot removed the CICD Run CI/CD label May 13, 2026

Piinks added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels May 13, 2026

auto-submit Bot added this pull request to the merge queue May 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 15, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2026

rkishan516 added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2026

auto-submit Bot added this pull request to the merge queue May 16, 2026

Merged via the queue into flutter:master with commit a8c3b09 May 16, 2026
176 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2026

github-project-automation Bot moved this from In Progress to Done in Test cross-imports Review Queue May 16, 2026

Renzo-Olivares mentioned this pull request Jun 24, 2026

(Test cross-imports) Tests should go in the library that they're testing #177414

Open

57 tasks

		@@ -0,0 +1,35 @@
		// Copyright 2014 The Flutter Authors. All rights reserved.

Uh oh!

Conversation

master-wayne7 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

rkishan516 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

justinmc commented Apr 15, 2026

Uh oh!

master-wayne7 commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

master-wayne7 commented Apr 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

rkishan516 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented May 12, 2026

Uh oh!

master-wayne7 commented May 13, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

master-wayne7 commented Apr 15, 2026 •

edited

Loading

master-wayne7 commented Apr 16, 2026 •

edited

Loading

justinmc left a comment •

edited

Loading