Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan by b-luk · Pull Request #181292 · flutter/flutter

b-luk · 2026-01-21T22:29:38Z

The shader has uniform vec3[4] color_array; and sets fragColor = vec4(color_array[3].xyz, 1);. Update the test to use the correct indexes for color_array[3]: 9, 10, 11 instead of 12, 13, 14.
Skip the test for metal. Metal seems like it has some weird index padding issue. From testing it out:
- color_array[0].xyz is set when setting indexes 0, 1, 2, as expected.
- color_array[1].xyz should use indexes 3, 4, 5. But it seems to use indexes 4, 5, 6. Maybe there's some incorrect math making it skip index 3.
- color_array[2].xyz should use indexes 6, 7, 8. But it seems to use indexes 8, 9, 10. Maybe there's some incorrect math making it skip indexes 3 and 7.
- color_array[3].xyz should use indexes 9, 10, 11. But it seems to be impossible to set. Maybe it skips indexes 3, 7, and 11 and then tries to look at out-of-bounds indexes 12, 13, 14?
Fix incorrect logic in the _expectShaderRendersColor() method.
- The 4 bytes for each pixel of an image are in the format 0xRRGGBBAA.
- This method used to use renderedBytes.buffer.asUint32List(). This reads 4 bytes to a Uint32, but uses Endian.host endianness. Maybe this differs on different platforms, but on my Mac this is little endian. So the image's 0xRRGGBBAA bytes are read into a Uint32 as 0xAABBGGRR.
- This is then compared to the target Color.value, which is in ARGB32 format: 0xAARRGGBB.
- So it's comparing the each image's pixel as 0xAABBGGRR to the target color as 0xAARRGGBB. It switches the RR and BB channels for every comparison.
- This did not result in any test failures because _expectShaderRendersColor() is only ever used as a helper function for _expectShaderRendersGreen() and _expectShaderRendersBlack(). And (un)luckily, those perfectly ignore the RR and BB channels.
- Fix the logic by reading each pixel's bytes with separate getUint8() calls and parsing them into a Color with fromARGB(), using the correct byte offsets for each channel.

Partially addresses #180932. Re-enables the test for Vulkan, but it's still disabled for Metal.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request re-enables a disabled test for Vulkan by correcting uniform indices and adds a skip for Metal. It also commendably fixes a latent endian-related bug in the _expectShaderRendersColor test helper, making pixel color verification more robust. The changes are well-explained, significantly improving test correctness and coverage. I have one suggestion to make the test helper code more idiomatic.

gemini-code-assist · 2026-01-21T22:31:53Z

  test(name, () async {
    if (!impellerEnabled) {
      print('skipped for Skia');
      return;
    }
    await callback();
-  });
+  }, skip: skip);


The test function from package:test provides a skip parameter that can be used to conditionally skip tests. Using it would make the intent clearer and is more idiomatic. You can combine the existing !impellerEnabled check with the new skip parameter to simplify this helper function.

test( name, callback, skip: !impellerEnabled ? 'skipped for Skia' : skip, );

gaaclarke

LGTM, thanks!

auto-submit · 2026-01-22T02:04:10Z

autosubmit label was removed for flutter/flutter/181292, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…priately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292)

Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions) flutter/flutter@48c2475...bfc9041 2026-01-23 matt.kosarek@canonical.com No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379) 2026-01-23 50643541+Mairramer@users.noreply.github.com Reset TextFormField to initial value after state change (flutter/flutter#181199) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248) 2026-01-23 43635580+Lilian-C@users.noreply.github.com Add bottom navigation bar item semantics label (flutter/flutter#180577) 2026-01-23 58190796+MitchellGoodwin@users.noreply.github.com Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269) 2026-01-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364) 2026-01-23 34871572+gmackall@users.noreply.github.com Reland hybrid views test (flutter/flutter#181336) 2026-01-23 git@reb0.org Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074) 2026-01-23 dkwingsmt@users.noreply.github.com Fix leaks in `flutter_test` tests (flutter/flutter#180879) 2026-01-23 97480502+b-luk@users.noreply.github.com Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292) 2026-01-23 bkonyi@google.com [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335) 2026-01-23 jason-simmons@users.noreply.github.com [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201) 2026-01-23 97480502+b-luk@users.noreply.github.com Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093) 2026-01-23 15619084+vashworth@users.noreply.github.com Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348) 2026-01-22 69134234+sutes-work@users.noreply.github.com Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347) 2026-01-22 sokolovskyi.konstantin@gmail.com Add ExpansibleController.toggle method. (flutter/flutter#181320) 2026-01-22 42980667+srivats22@users.noreply.github.com Fixes Typo in codebase (flutter/flutter#181256) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346) 2026-01-22 ahmedsameha1@gmail.com Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954) 2026-01-22 jason-simmons@users.noreply.github.com Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331) 2026-01-22 kazbek.sultanov.doc@gmail.com Fix remove material import textfield (flutter/flutter#181254) 2026-01-22 15619084+vashworth@users.noreply.github.com Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324) 2026-01-22 engine-flutter-autoroll@skia.org Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305) 2026-01-22 120639059+Enderjua@users.noreply.github.com [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041) 2026-01-22 146823759+brahim-guaali@users.noreply.github.com Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237) 2026-01-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297) 2026-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181295) 2026-01-22 30870216+gaaclarke@users.noreply.github.com Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013) 2026-01-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290) 2026-01-21 engine-flutter-autoroll@skia.org Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289) 2026-01-21 brackenavaron@gmail.com fix description for semantics finders (flutter/flutter#181214) 2026-01-21 ahmedsameha1@gmail.com Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021) 2026-01-21 ahmedsameha1@gmail.com Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906) 2026-01-21 magder@google.com Bring Linux coverage out of bringup (flutter/flutter#181280) ...

…ads vec3 uniform arrays' test on Vulkan (flutter#181292) - The [shader](https://github.com/flutter/flutter/blob/3b206173454ec192938126322c58b5a1f090652f/engine/src/flutter/lib/ui/fixtures/shaders/general_shaders/vec3_uniform.frag) has `uniform vec3[4] color_array;` and sets `fragColor = vec4(color_array[3].xyz, 1);`. Update the test to use the correct indexes for `color_array[3]`: 9, 10, 11 instead of 12, 13, 14. - Skip the test for metal. Metal seems like it has some weird index padding issue. From testing it out: - `color_array[0].xyz` is set when setting indexes 0, 1, 2, as expected. - `color_array[1].xyz` should use indexes 3, 4, 5. But it seems to use indexes 4, 5, 6. Maybe there's some incorrect math making it skip index 3. - `color_array[2].xyz` should use indexes 6, 7, 8. But it seems to use indexes 8, 9, 10. Maybe there's some incorrect math making it skip indexes 3 and 7. - `color_array[3].xyz` should use indexes 9, 10, 11. But it seems to be impossible to set. Maybe it skips indexes 3, 7, and 11 and then tries to look at out-of-bounds indexes 12, 13, 14? - Fix incorrect logic in the `_expectShaderRendersColor()` method. - The 4 bytes for each pixel of an image are in the format `0xRRGGBBAA`. - This method used to use `renderedBytes.buffer.asUint32List()`. This reads 4 bytes to a Uint32, but uses `Endian.host` endianness. Maybe this differs on different platforms, but on my Mac this is little endian. So the image's `0xRRGGBBAA` bytes are read into a Uint32 as `0xAABBGGRR`. - This is then compared to the target `Color.value`, which is in ARGB32 format: `0xAARRGGBB`. - So it's comparing the each image's pixel as `0xAABBGGRR` to the target color as `0xAARRGGBB`. It switches the RR and BB channels for every comparison. - This did not result in any test failures because `_expectShaderRendersColor()` is only ever used as a helper function for `_expectShaderRendersGreen()` and `_expectShaderRendersBlack()`. And (un)luckily, those perfectly ignore the RR and BB channels. - Fix the logic by reading each pixel's bytes with separate `getUint8()` calls and parsing them into a `Color` with `fromARGB()`, using the correct byte offsets for each channel. Partially addresses flutter#180932. Re-enables the test for Vulkan, but it's still disabled for Metal. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

) Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions) flutter/flutter@48c2475...bfc9041 2026-01-23 matt.kosarek@canonical.com No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379) 2026-01-23 50643541+Mairramer@users.noreply.github.com Reset TextFormField to initial value after state change (flutter/flutter#181199) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248) 2026-01-23 43635580+Lilian-C@users.noreply.github.com Add bottom navigation bar item semantics label (flutter/flutter#180577) 2026-01-23 58190796+MitchellGoodwin@users.noreply.github.com Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269) 2026-01-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364) 2026-01-23 34871572+gmackall@users.noreply.github.com Reland hybrid views test (flutter/flutter#181336) 2026-01-23 git@reb0.org Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074) 2026-01-23 dkwingsmt@users.noreply.github.com Fix leaks in `flutter_test` tests (flutter/flutter#180879) 2026-01-23 97480502+b-luk@users.noreply.github.com Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292) 2026-01-23 bkonyi@google.com [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335) 2026-01-23 jason-simmons@users.noreply.github.com [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201) 2026-01-23 97480502+b-luk@users.noreply.github.com Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093) 2026-01-23 15619084+vashworth@users.noreply.github.com Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348) 2026-01-22 69134234+sutes-work@users.noreply.github.com Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347) 2026-01-22 sokolovskyi.konstantin@gmail.com Add ExpansibleController.toggle method. (flutter/flutter#181320) 2026-01-22 42980667+srivats22@users.noreply.github.com Fixes Typo in codebase (flutter/flutter#181256) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346) 2026-01-22 ahmedsameha1@gmail.com Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954) 2026-01-22 jason-simmons@users.noreply.github.com Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331) 2026-01-22 kazbek.sultanov.doc@gmail.com Fix remove material import textfield (flutter/flutter#181254) 2026-01-22 15619084+vashworth@users.noreply.github.com Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324) 2026-01-22 engine-flutter-autoroll@skia.org Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305) 2026-01-22 120639059+Enderjua@users.noreply.github.com [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041) 2026-01-22 146823759+brahim-guaali@users.noreply.github.com Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237) 2026-01-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297) 2026-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181295) 2026-01-22 30870216+gaaclarke@users.noreply.github.com Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013) 2026-01-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290) 2026-01-21 engine-flutter-autoroll@skia.org Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289) 2026-01-21 brackenavaron@gmail.com fix description for semantics finders (flutter/flutter#181214) 2026-01-21 ahmedsameha1@gmail.com Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021) 2026-01-21 ahmedsameha1@gmail.com Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906) 2026-01-21 magder@google.com Bring Linux coverage out of bringup (flutter/flutter#181280) ...

initial commit

6d07ac8

b-luk requested a review from gaaclarke January 21, 2026 22:29

github-actions Bot added the engine flutter/engine related. See also e: labels. label Jan 21, 2026

gemini-code-assist Bot reviewed Jan 21, 2026

View reviewed changes

gaaclarke approved these changes Jan 22, 2026

View reviewed changes

b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2026

Merge branch 'master' into fixfragmentshadertestvec3uniformarray

f010070

b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2026

auto-submit Bot added this pull request to the merge queue Jan 23, 2026

Merged via the queue into flutter:master with commit 65701bd Jan 23, 2026
178 of 179 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2026

engine-flutter-autoroll mentioned this pull request Jan 23, 2026

Roll Flutter from 48c247582e45 to bfc9041eb118 (173 revisions) flutter/packages#10862

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026

65701bd31 Re-enable fragment_shader_tests.dart 'Shader Compiler appro…

af371a8

…priately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292)

b-luk deleted the fixfragmentshadertestvec3uniformarray branch January 23, 2026 18:03

b-luk mentioned this pull request Jan 23, 2026

Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test #180932

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan#181292

Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan#181292
auto-submit[bot] merged 2 commits into
flutter:masterfrom
b-luk:fixfragmentshadertestvec3uniformarray

b-luk commented Jan 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Uh oh!

gaaclarke left a comment

Uh oh!

auto-submit Bot commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

b-luk commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

b-luk commented Jan 21, 2026 •

edited

Loading