Skip to content

Revert DropdownMenu non-nullable breaking change#181074

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
Gustl22:180121-null-dropdown
Jan 23, 2026
Merged

Revert DropdownMenu non-nullable breaking change#181074
auto-submit[bot] merged 6 commits into
flutter:masterfrom
Gustl22:180121-null-dropdown

Conversation

@Gustl22

@Gustl22 Gustl22 commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

As explained in #180121 the PR #176711 is a breaking change, which must be properly documented.

Closes #180121

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 16, 2026
@Gustl22 Gustl22 changed the title fix: Allow null entry to clear DropdownMenu (#180121) Revert DropdownMenu non-nullable breaking change Jan 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a breaking change by allowing DropdownMenu to accept nullable types for its entries. This is achieved by removing the extends Object constraint on the generic type T in DropdownMenu and _DropdownMenuState. A regression test has been added to verify that entries with null values can be selected.

My feedback focuses on improving the new test case to align with the widget's API contract, ensuring the test is robust and clear.

Comment thread packages/flutter/test/material/dropdown_menu_test.dart Outdated
@dkwingsmt

dkwingsmt commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

I'm ok with reverting the breaking change until the need for the change is further justified. That being said, why are we not reverting the entirety of #176711 ? Why is the DropdownMenuFormField part left out?

@LongCatIsLooong LongCatIsLooong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The revert change LGTM. Are you planning to cherry pick this revert?

@Gustl22 Gustl22 mentioned this pull request Jan 22, 2026
9 tasks
@Gustl22

Gustl22 commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

@dkwingsmt I think the docs are still valid. I have overseen the other part, and added regression tests. You can also push into my branch or cherry-pick the regression tests if wanted.

@dkwingsmt dkwingsmt requested a review from justinmc January 23, 2026 00:05
@dkwingsmt

Copy link
Copy Markdown
Contributor

@Gustl22 Thank you! Can you address the Linux analyze check? If we can land this PR I'll close mine, which was only opened because I wanted to speed up the process.

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 assuming this passes tests now. Thanks for adding a regression test and for keeping the documentation changes from #176711.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2026
@Gustl22

Gustl22 commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

I have to go to bed, sorry ^^ (already middle in the night in europe) Feel free to push if something is missing. Thank you for letting me contribute the revert before going stable 🙏

@auto-submit auto-submit Bot added this pull request to the merge queue Jan 23, 2026
Merged via the queue into flutter:master with commit 91a8eb9 Jan 23, 2026
70 of 71 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2026
Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions)

flutter/flutter@48c2475...bfc9041

2026-01-23 matt.kosarek@canonical.com No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339)
2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249)
2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379)
2026-01-23 50643541+Mairramer@users.noreply.github.com Reset TextFormField to initial value after state change (flutter/flutter#181199)
2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375)
2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370)
2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248)
2026-01-23 43635580+Lilian-C@users.noreply.github.com Add bottom navigation bar item semantics label (flutter/flutter#180577)
2026-01-23 58190796+MitchellGoodwin@users.noreply.github.com Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269)
2026-01-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365)
2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364)
2026-01-23 34871572+gmackall@users.noreply.github.com Reland hybrid views test (flutter/flutter#181336)
2026-01-23 git@reb0.org Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074)
2026-01-23 dkwingsmt@users.noreply.github.com Fix leaks in `flutter_test` tests (flutter/flutter#180879)
2026-01-23 97480502+b-luk@users.noreply.github.com Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292)
2026-01-23 bkonyi@google.com [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335)
2026-01-23 jason-simmons@users.noreply.github.com [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201)
2026-01-23 97480502+b-luk@users.noreply.github.com Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093)
2026-01-23 15619084+vashworth@users.noreply.github.com Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348)
2026-01-22 69134234+sutes-work@users.noreply.github.com Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347)
2026-01-22 sokolovskyi.konstantin@gmail.com Add ExpansibleController.toggle method. (flutter/flutter#181320)
2026-01-22 42980667+srivats22@users.noreply.github.com Fixes Typo in codebase (flutter/flutter#181256)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346)
2026-01-22 ahmedsameha1@gmail.com Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954)
2026-01-22 jason-simmons@users.noreply.github.com Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331)
2026-01-22 kazbek.sultanov.doc@gmail.com Fix remove material import textfield (flutter/flutter#181254)
2026-01-22 15619084+vashworth@users.noreply.github.com Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324)
2026-01-22 engine-flutter-autoroll@skia.org Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305)
2026-01-22 120639059+Enderjua@users.noreply.github.com [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041)
2026-01-22 146823759+brahim-guaali@users.noreply.github.com Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237)
2026-01-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297)
2026-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181295)
2026-01-22 30870216+gaaclarke@users.noreply.github.com Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013)
2026-01-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290)
2026-01-21 engine-flutter-autoroll@skia.org Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289)
2026-01-21 brackenavaron@gmail.com fix description for semantics finders (flutter/flutter#181214)
2026-01-21 ahmedsameha1@gmail.com Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021)
2026-01-21 ahmedsameha1@gmail.com Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906)
2026-01-21 magder@google.com Bring Linux coverage out of bringup (flutter/flutter#181280)
...
auto-submit Bot pushed a commit that referenced this pull request Jan 27, 2026
This PR cherrypicks #181074 into beta, which is mostly a revert of #176711 (except that some docs are left unreverted and a few new tests are added.) This is needed to address a breakage as described in #180121.

**Impacted Users:** Apps that use `DropdownMenu` or `DropdownMenuFormField` for a nullable class, such as `DropdownMenu<int?>`.

**Impact Description:** Can not compile.

**Workaround:** Yes, through non-trivial changes. For example, the developer can replace  `DropdownMenu<int?>` with `DropdownMenu<Maybe<int>>`, as long as they import `Maybe` or create their own equivalence. 

**Risk:** Low. This PR is basically a revert.

**Test Coverage:** Yes. The widget has high test coverage.

**Validation Steps:** The PR compiles and tests pass.
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
As explained in flutter#180121 the PR flutter#176711 is a breaking change, which must
be properly documented.

Closes flutter#180121

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
Xbectordash pushed a commit to Xbectordash/abhi_flutter_fork that referenced this pull request May 13, 2026
This PR cherrypicks flutter#181074 into beta, which is mostly a revert of flutter#176711 (except that some docs are left unreverted and a few new tests are added.) This is needed to address a breakage as described in flutter#180121.

**Impacted Users:** Apps that use `DropdownMenu` or `DropdownMenuFormField` for a nullable class, such as `DropdownMenu<int?>`.

**Impact Description:** Can not compile.

**Workaround:** Yes, through non-trivial changes. For example, the developer can replace  `DropdownMenu<int?>` with `DropdownMenu<Maybe<int>>`, as long as they import `Maybe` or create their own equivalence.

**Risk:** Low. This PR is basically a revert.

**Test Coverage:** Yes. The widget has high test coverage.

**Validation Steps:** The PR compiles and tests pass.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)

Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions)

flutter/flutter@48c2475...bfc9041

2026-01-23 matt.kosarek@canonical.com No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339)
2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249)
2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379)
2026-01-23 50643541+Mairramer@users.noreply.github.com Reset TextFormField to initial value after state change (flutter/flutter#181199)
2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375)
2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370)
2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248)
2026-01-23 43635580+Lilian-C@users.noreply.github.com Add bottom navigation bar item semantics label (flutter/flutter#180577)
2026-01-23 58190796+MitchellGoodwin@users.noreply.github.com Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269)
2026-01-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365)
2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364)
2026-01-23 34871572+gmackall@users.noreply.github.com Reland hybrid views test (flutter/flutter#181336)
2026-01-23 git@reb0.org Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074)
2026-01-23 dkwingsmt@users.noreply.github.com Fix leaks in `flutter_test` tests (flutter/flutter#180879)
2026-01-23 97480502+b-luk@users.noreply.github.com Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292)
2026-01-23 bkonyi@google.com [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335)
2026-01-23 jason-simmons@users.noreply.github.com [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201)
2026-01-23 97480502+b-luk@users.noreply.github.com Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093)
2026-01-23 15619084+vashworth@users.noreply.github.com Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348)
2026-01-22 69134234+sutes-work@users.noreply.github.com Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347)
2026-01-22 sokolovskyi.konstantin@gmail.com Add ExpansibleController.toggle method. (flutter/flutter#181320)
2026-01-22 42980667+srivats22@users.noreply.github.com Fixes Typo in codebase (flutter/flutter#181256)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346)
2026-01-22 ahmedsameha1@gmail.com Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954)
2026-01-22 jason-simmons@users.noreply.github.com Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331)
2026-01-22 kazbek.sultanov.doc@gmail.com Fix remove material import textfield (flutter/flutter#181254)
2026-01-22 15619084+vashworth@users.noreply.github.com Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324)
2026-01-22 engine-flutter-autoroll@skia.org Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311)
2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307)
2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305)
2026-01-22 120639059+Enderjua@users.noreply.github.com [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041)
2026-01-22 146823759+brahim-guaali@users.noreply.github.com Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237)
2026-01-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297)
2026-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181295)
2026-01-22 30870216+gaaclarke@users.noreply.github.com Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013)
2026-01-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290)
2026-01-21 engine-flutter-autoroll@skia.org Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289)
2026-01-21 brackenavaron@gmail.com fix description for semantics finders (flutter/flutter#181214)
2026-01-21 ahmedsameha1@gmail.com Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021)
2026-01-21 ahmedsameha1@gmail.com Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906)
2026-01-21 magder@google.com Bring Linux coverage out of bringup (flutter/flutter#181280)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-nullable DropdownMenu is breaking change

4 participants