Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU...#181139
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Fuchsia GN SDK and refactors the logging implementation to use the new APIs provided by the updated SDK. This is a good cleanup that removes the custom LogState and LogInterestListener implementation in favor of the SDK's fuchsia_logging::LogSettingsBuilder and fuchsia_logging::LogBufferBuilder. The changes in BUILD.gn, logging.cc, and the main.cc files are consistent with this goal. I have one suggestion in fml/logging.cc to improve the readability and maintainability of the new GetProcessName helper function.
a472111 to
a6b1926
Compare
and fix logging which has changed. Bug: b/456458551
Contributor
|
Thank you, lgtm. |
zijiehe-google-com
approved these changes
Jan 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 23, 2026
Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions) flutter/flutter@48c2475...bfc9041 2026-01-23 matt.kosarek@canonical.com No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379) 2026-01-23 50643541+Mairramer@users.noreply.github.com Reset TextFormField to initial value after state change (flutter/flutter#181199) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248) 2026-01-23 43635580+Lilian-C@users.noreply.github.com Add bottom navigation bar item semantics label (flutter/flutter#180577) 2026-01-23 58190796+MitchellGoodwin@users.noreply.github.com Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269) 2026-01-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364) 2026-01-23 34871572+gmackall@users.noreply.github.com Reland hybrid views test (flutter/flutter#181336) 2026-01-23 git@reb0.org Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074) 2026-01-23 dkwingsmt@users.noreply.github.com Fix leaks in `flutter_test` tests (flutter/flutter#180879) 2026-01-23 97480502+b-luk@users.noreply.github.com Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292) 2026-01-23 bkonyi@google.com [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335) 2026-01-23 jason-simmons@users.noreply.github.com [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201) 2026-01-23 97480502+b-luk@users.noreply.github.com Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093) 2026-01-23 15619084+vashworth@users.noreply.github.com Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348) 2026-01-22 69134234+sutes-work@users.noreply.github.com Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347) 2026-01-22 sokolovskyi.konstantin@gmail.com Add ExpansibleController.toggle method. (flutter/flutter#181320) 2026-01-22 42980667+srivats22@users.noreply.github.com Fixes Typo in codebase (flutter/flutter#181256) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346) 2026-01-22 ahmedsameha1@gmail.com Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954) 2026-01-22 jason-simmons@users.noreply.github.com Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331) 2026-01-22 kazbek.sultanov.doc@gmail.com Fix remove material import textfield (flutter/flutter#181254) 2026-01-22 15619084+vashworth@users.noreply.github.com Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324) 2026-01-22 engine-flutter-autoroll@skia.org Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305) 2026-01-22 120639059+Enderjua@users.noreply.github.com [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041) 2026-01-22 146823759+brahim-guaali@users.noreply.github.com Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237) 2026-01-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297) 2026-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181295) 2026-01-22 30870216+gaaclarke@users.noreply.github.com Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013) 2026-01-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290) 2026-01-21 engine-flutter-autoroll@skia.org Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289) 2026-01-21 brackenavaron@gmail.com fix description for semantics finders (flutter/flutter#181214) 2026-01-21 ahmedsameha1@gmail.com Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021) 2026-01-21 ahmedsameha1@gmail.com Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906) 2026-01-21 magder@google.com Bring Linux coverage out of bringup (flutter/flutter#181280) ...
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…flutter#181139) and fix logging which has changed. Bug: b/456458551 <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> This fixes the Fuchsia SDK roll which was blocked due to some logging changes that were made. This fixes internal bug b/456458551. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: zijiehe@ <68449066+zijiehe-google-com@users.noreply.github.com>
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
) Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions) flutter/flutter@48c2475...bfc9041 2026-01-23 matt.kosarek@canonical.com No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379) 2026-01-23 50643541+Mairramer@users.noreply.github.com Reset TextFormField to initial value after state change (flutter/flutter#181199) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375) 2026-01-23 engine-flutter-autoroll@skia.org Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370) 2026-01-23 kazbek.sultanov.doc@gmail.com Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248) 2026-01-23 43635580+Lilian-C@users.noreply.github.com Add bottom navigation bar item semantics label (flutter/flutter#180577) 2026-01-23 58190796+MitchellGoodwin@users.noreply.github.com Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269) 2026-01-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365) 2026-01-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364) 2026-01-23 34871572+gmackall@users.noreply.github.com Reland hybrid views test (flutter/flutter#181336) 2026-01-23 git@reb0.org Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074) 2026-01-23 dkwingsmt@users.noreply.github.com Fix leaks in `flutter_test` tests (flutter/flutter#180879) 2026-01-23 97480502+b-luk@users.noreply.github.com Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292) 2026-01-23 bkonyi@google.com [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335) 2026-01-23 jason-simmons@users.noreply.github.com [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201) 2026-01-23 97480502+b-luk@users.noreply.github.com Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093) 2026-01-23 15619084+vashworth@users.noreply.github.com Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348) 2026-01-22 69134234+sutes-work@users.noreply.github.com Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347) 2026-01-22 sokolovskyi.konstantin@gmail.com Add ExpansibleController.toggle method. (flutter/flutter#181320) 2026-01-22 42980667+srivats22@users.noreply.github.com Fixes Typo in codebase (flutter/flutter#181256) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346) 2026-01-22 ahmedsameha1@gmail.com Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954) 2026-01-22 jason-simmons@users.noreply.github.com Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331) 2026-01-22 kazbek.sultanov.doc@gmail.com Fix remove material import textfield (flutter/flutter#181254) 2026-01-22 15619084+vashworth@users.noreply.github.com Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324) 2026-01-22 engine-flutter-autoroll@skia.org Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311) 2026-01-22 engine-flutter-autoroll@skia.org Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307) 2026-01-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305) 2026-01-22 120639059+Enderjua@users.noreply.github.com [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041) 2026-01-22 146823759+brahim-guaali@users.noreply.github.com Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237) 2026-01-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297) 2026-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181295) 2026-01-22 30870216+gaaclarke@users.noreply.github.com Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013) 2026-01-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290) 2026-01-21 engine-flutter-autoroll@skia.org Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289) 2026-01-21 brackenavaron@gmail.com fix description for semantics finders (flutter/flutter#181214) 2026-01-21 ahmedsameha1@gmail.com Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021) 2026-01-21 ahmedsameha1@gmail.com Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906) 2026-01-21 magder@google.com Bring Linux coverage out of bringup (flutter/flutter#181280) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and fix logging which has changed.
Bug: b/456458551
This fixes the Fuchsia SDK roll which was blocked due to some logging changes that were made.
This fixes internal bug b/456458551.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.