[skia] Update SkSerialProcs to use new type #179347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several serialization callback functions to use the new SkSerialReturnType from Skia. This change aligns the codebase with an upstream API update in Skia, replacing sk_sp<SkData> with the new type, which is an alias for sk_sp<const SkData>. The modifications are applied consistently in function declarations, definitions, and a lambda function. The changes are correct and serve as a preparatory refactoring. I have reviewed the changes and found no issues.
chinmaygarde
approved these changes
Dec 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
This was referenced Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
This lets us eventually use the const SkData version added in https://skia-review.googlesource.com/c/skia/+/1109339 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 10, 2025
Manual roll requested by tarrinneal@google.com flutter/flutter@b2de367...6a1f5b7 2025-12-09 31510811+jwlilly@users.noreply.github.com Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978) 2025-12-09 engine-flutter-autoroll@skia.org Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625) 2025-12-09 kjlubick@users.noreply.github.com [skia] Update SkSerialProcs to use new type (flutter/flutter#179347) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608) 2025-12-09 1961493+harryterkelsen@users.noreply.github.com Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595) 2025-12-08 fluttergithubbot@gmail.com Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594) 2025-12-08 fluttergithubbot@gmail.com Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589) 2025-12-08 kevmoo@users.noreply.github.com MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546) 2025-12-08 97480502+b-luk@users.noreply.github.com Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292) 2025-12-08 matt.boetger@gmail.com Android implementation of content sizing (flutter/flutter#176063) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587) 2025-12-08 matt.boetger@gmail.com Redistribute TESTOWNERS for Android team (flutter/flutter#179464) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
Now that #179347 landed (update: waiting on https://skia-review.googlesource.com/c/skia/+/1122216 to land and roll), we should be able to make sure Flutter doesn't accidentally backslide. This also removes defines that have been removed from Skia. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Jan 6, 2026
Client CLs: - http://ag/37268110 - http://ag/37268030 - http://ag/37269325 - https://crrev.com/c/7199914 - flutter/flutter#179347 - flutter/flutter#179684 Change-Id: Ia059533903a9117198f843c67f0eb11fa6a561f3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1114776 Auto-Submit: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us eventually use the const SkData version added in https://skia-review.googlesource.com/c/skia/+/1109339
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.