Make sure that a CupertinoListTile doesn't crash in 0x0 environment by ahmedsameha1 · Pull Request #179109 · flutter/flutter

ahmedsameha1 · 2025-11-26T06:19:46Z

This is my attempt to handle #6537 for the CupertinoListTile widget.

gemini-code-assist

Code Review

This pull request adds a regression test to ensure that CupertinoListTile does not crash when rendered in a zero-sized environment, addressing a previously reported issue. The added test is well-structured and correctly simulates the problematic scenario. I have suggested a minor enhancement to the test to more closely match the conditions of the original bug report, which involved a leading widget.

gemini-code-assist · 2025-11-26T06:21:54Z

+    await tester.pumpWidget(
+      const CupertinoApp(
+        home: Center(
+          child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'))),


This is a good regression test. To better cover the scenario described in the original issue, which was related to calculations involving the leading widget, I suggest also testing the case where a leading widget is present. This will make the test more robust against future regressions related to this part of the layout logic.

Suggested change

child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'))),

child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'), leading: Icon(CupertinoIcons.add))),

victorsanni · 2025-12-02T18:43:57Z

+      const CupertinoApp(
+        home: Center(
+          child: SizedBox.shrink(
+            child: CupertinoListTile(title: Text('X'), trailing: CupertinoListTileChevron()),


I think it puts the chevron in by default? My request was we should expect that the chevron is correctly shrunk.

Do you want me to assert that the size of the CupertinoListTileChevron is zero here?

I think this test is fine since we only want to verify that ListTile has size zero.

dkwingsmt

Checklist:

The test is in the correct file
The test name goes “does not crash at zero area”
The target widget is wrapped by Center (or is fullscreen)
The target widget does not have an overlay, or the overlay is tested
The target widget is expected to have a size of exactly Size.zero

dkwingsmt · 2025-12-05T22:08:46Z

+      const CupertinoApp(
+        home: Center(
+          child: SizedBox.shrink(
+            child: CupertinoListTile(title: Text('X'), trailing: CupertinoListTileChevron()),


I think this test is fine since we only want to verify that ListTile has size zero.

…onment (flutter/flutter#179109)

…lutter#179109) This is my attempt to handle flutter#6537 for the CupertinoListTile widget. --------- Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

Manual roll requested by tarrinneal@google.com flutter/flutter@b2de367...6a1f5b7 2025-12-09 31510811+jwlilly@users.noreply.github.com Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978) 2025-12-09 engine-flutter-autoroll@skia.org Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625) 2025-12-09 kjlubick@users.noreply.github.com [skia] Update SkSerialProcs to use new type (flutter/flutter#179347) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608) 2025-12-09 1961493+harryterkelsen@users.noreply.github.com Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595) 2025-12-08 fluttergithubbot@gmail.com Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594) 2025-12-08 fluttergithubbot@gmail.com Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589) 2025-12-08 kevmoo@users.noreply.github.com MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546) 2025-12-08 97480502+b-luk@users.noreply.github.com Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292) 2025-12-08 matt.boetger@gmail.com Android implementation of content sizing (flutter/flutter#176063) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587) 2025-12-08 matt.boetger@gmail.com Redistribute TESTOWNERS for Android team (flutter/flutter#179464) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…0593) Manual roll requested by tarrinneal@google.com flutter/flutter@b2de367...6a1f5b7 2025-12-09 31510811+jwlilly@users.noreply.github.com Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978) 2025-12-09 engine-flutter-autoroll@skia.org Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625) 2025-12-09 kjlubick@users.noreply.github.com [skia] Update SkSerialProcs to use new type (flutter/flutter#179347) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608) 2025-12-09 1961493+harryterkelsen@users.noreply.github.com Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595) 2025-12-08 fluttergithubbot@gmail.com Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594) 2025-12-08 fluttergithubbot@gmail.com Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589) 2025-12-08 kevmoo@users.noreply.github.com MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546) 2025-12-08 97480502+b-luk@users.noreply.github.com Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292) 2025-12-08 matt.boetger@gmail.com Android implementation of content sizing (flutter/flutter#176063) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587) 2025-12-08 matt.boetger@gmail.com Redistribute TESTOWNERS for Android team (flutter/flutter#179464) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…onment (flutter/flutter#179109)

…0593) Manual roll requested by tarrinneal@google.com flutter/flutter@b2de367...6a1f5b7 2025-12-09 31510811+jwlilly@users.noreply.github.com Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978) 2025-12-09 engine-flutter-autoroll@skia.org Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625) 2025-12-09 kjlubick@users.noreply.github.com [skia] Update SkSerialProcs to use new type (flutter/flutter#179347) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608) 2025-12-09 1961493+harryterkelsen@users.noreply.github.com Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595) 2025-12-08 fluttergithubbot@gmail.com Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594) 2025-12-08 fluttergithubbot@gmail.com Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589) 2025-12-08 kevmoo@users.noreply.github.com MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546) 2025-12-08 97480502+b-luk@users.noreply.github.com Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292) 2025-12-08 matt.boetger@gmail.com Android implementation of content sizing (flutter/flutter#176063) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587) 2025-12-08 matt.boetger@gmail.com Redistribute TESTOWNERS for Android team (flutter/flutter#179464) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Make sure that a CupertinoListTile doesn't crash in 0x0 environment

57e0068

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Nov 26, 2025

gemini-code-assist Bot reviewed Nov 26, 2025

View reviewed changes

victorsanni approved these changes Nov 26, 2025

View reviewed changes

victorsanni requested a review from dkwingsmt November 26, 2025 18:22

Add a CupertinoListTileChevron in the CupertinoListTile zero area test

1a9a0e7

victorsanni approved these changes Dec 2, 2025

View reviewed changes

dkwingsmt approved these changes Dec 5, 2025

View reviewed changes

Merge branch 'master' into handle#6537-CupertinoListTile

d49da4b

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2025

auto-submit Bot added this pull request to the merge queue Dec 5, 2025

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Dec 6, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2025

Merge branch 'master' into handle#6537-CupertinoListTile

b8912b3

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025

auto-submit Bot added this pull request to the merge queue Dec 8, 2025

Merged via the queue into flutter:master with commit 61033df Dec 8, 2025
71 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

edd8832

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 9, 2025

Roll Flutter from b2de367c41e0 to a4959f7544f1 (17 revisions) flutter/packages#10588

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

5fc0277

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 9, 2025

Roll Flutter from b2de367c41e0 to 17797780cd94 (18 revisions) flutter/packages#10589

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

a02f36f

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 9, 2025

Roll Flutter from b2de367c41e0 to 6c7de50493a5 (19 revisions) flutter/packages#10590

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

a159029

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 9, 2025

Roll Flutter from b2de367c41e0 to af7b52181eb7 (20 revisions) flutter/packages#10591

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

ff0bf7b

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 9, 2025

Roll Flutter from b2de367c41e0 to 981a39f5512a (21 revisions) flutter/packages#10592

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

173216a

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 9, 2025

Manual roll Flutter from b2de367c41e0 to 6a1f5b7f85a4 (22 revisions) flutter/packages#10593

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

fd4ead6

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 10, 2025

Roll Flutter from b2de367c41e0 to 6519f9991155 (43 revisions) flutter/packages#10596

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

6accac0

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 10, 2025

Roll Flutter from b2de367c41e0 to 5b74a3b8e8f8 (44 revisions) flutter/packages#10597

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

b7614eb

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 10, 2025

Roll Flutter from b2de367c41e0 to 8147c3ab3ce2 (45 revisions) flutter/packages#10598

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

5918920

…onment (flutter/flutter#179109)

engine-flutter-autoroll mentioned this pull request Dec 10, 2025

Roll Flutter from b2de367c41e0 to 545b8c33ed86 (46 revisions) flutter/packages#10600

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

61033df Make sure that a CupertinoListTile doesn't crash in 0x0 envir…

afa3ba2

…onment (flutter/flutter#179109)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make sure that a CupertinoListTile doesn't crash in 0x0 environment#179109

Make sure that a CupertinoListTile doesn't crash in 0x0 environment#179109
auto-submit[bot] merged 4 commits into
flutter:masterfrom
ahmedsameha1:handle#6537-CupertinoListTile

ahmedsameha1 commented Nov 26, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Nov 26, 2025

Uh oh!

victorsanni Dec 2, 2025

Uh oh!

ahmedsameha1 Dec 2, 2025

Uh oh!

dkwingsmt Dec 5, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'))),
	child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'), leading: Icon(CupertinoIcons.add))),

Uh oh!

Conversation

ahmedsameha1 commented Nov 26, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

ahmedsameha1 Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants