Marks Linux_mokey flutter_engine_group_performance to be flaky #179115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request marks the Linux_mokey flutter_engine_group_performance test as flaky by setting bringup: true in the .ci.yaml configuration file. My review suggests a minor adjustment to the comment format to align with the project's documented conventions for tracking flaky tests.
|
|
||
| # linux mokey benchmark | ||
| - name: Linux_mokey flutter_engine_group_performance | ||
| bringup: true # Flaky https://github.com/flutter/flutter/issues/179114 |
Contributor
There was a problem hiding this comment.
According to the docs/infra/Reducing-Test-Flakiness.md documentation (line 34), when marking a test as flaky, the convention is to add a comment in the format # TODO(username): github issue url on the line above bringup: true. This helps with tracking. Please consider updating the comment format and placement for consistency.
# TODO(<github_username>): https://github.com/flutter/flutter/issues/179114
bringup: true
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…er#179115) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_mokey flutter_engine_group_performance" } --> Issue link: flutter#179114
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 10, 2025
Manual roll requested by tarrinneal@google.com flutter/flutter@b2de367...6a1f5b7 2025-12-09 31510811+jwlilly@users.noreply.github.com Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351) 2025-12-09 ahmedsameha1@gmail.com Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978) 2025-12-09 engine-flutter-autoroll@skia.org Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625) 2025-12-09 kjlubick@users.noreply.github.com [skia] Update SkSerialProcs to use new type (flutter/flutter#179347) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617) 2025-12-09 engine-flutter-autoroll@skia.org Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608) 2025-12-09 1961493+harryterkelsen@users.noreply.github.com Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595) 2025-12-08 fluttergithubbot@gmail.com Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594) 2025-12-08 fluttergithubbot@gmail.com Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589) 2025-12-08 kevmoo@users.noreply.github.com MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546) 2025-12-08 97480502+b-luk@users.noreply.github.com Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292) 2025-12-08 matt.boetger@gmail.com Android implementation of content sizing (flutter/flutter#176063) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587) 2025-12-08 matt.boetger@gmail.com Redistribute TESTOWNERS for Android team (flutter/flutter#179464) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773) 2025-12-08 ahmedsameha1@gmail.com Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #179114