Update CHANGELOG.md for Flutter 3.38.3 #178935
Conversation
Added release notes for Flutter version 3.38.3.
Added instructions to run 'gclient sync' before and after updating dependencies.
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md file to include release notes for Flutter version 3.38.3. My review focuses on improving the clarity and usefulness of the new changelog entries to align with the project's documentation standards. I've suggested making the descriptions more problem-oriented and user-focused, as outlined in the repository's style guide and hotfix documentation best practices.
|
|
||
| ### [3.38.3](https://github.com/flutter/flutter/releases/tag/3.38.3) | ||
|
|
||
| - [flutter/178772](https://github.com/flutter/flutter/issues/178772) Flutter engine reports a different version than the framework. |
There was a problem hiding this comment.
This changelog entry is the same as the issue title. Per the project's documentation guidelines, documentation should be useful and explain the 'why' and 'how'.1 The current description doesn't clarify the user-facing impact. Please enhance the description to explain where this version mismatch appears and why it's a problem for users. For more specific guidance, refer to the docs/releases/Hotfix-Documentation-Best-Practices.md file.
| - [flutter/178772](https://github.com/flutter/flutter/issues/178772) Flutter engine reports a different version than the framework. | |
| - [flutter/178772](https://github.com/flutter/flutter/issues/178772) Fixes an issue where `flutter --version` could report a mismatched engine version, which could cause confusion for developers. |
Style Guide References
Footnotes
-
The style guide emphasizes that documentation should be useful, explaining the 'why' and 'how'. Changelog entries, as a form of documentation for releases, should clearly communicate the impact of a change to the user. ↩
| ### [3.38.3](https://github.com/flutter/flutter/releases/tag/3.38.3) | ||
|
|
||
| - [flutter/178772](https://github.com/flutter/flutter/issues/178772) Flutter engine reports a different version than the framework. | ||
| - [flutter/178804](https://github.com/flutter/flutter/issues/178804) Bump Dart version to [3.10.1](https://github.com/dart-lang/sdk/blob/3.10.1/CHANGELOG.md#3101). |
There was a problem hiding this comment.
This entry describes an action ('Bump Dart version') rather than the user-facing problem it solves. The style guide states that documentation should be useful.1 To make this entry more useful for users, please summarize the key fixes or improvements from the Dart 3.10.1 update that are relevant to Flutter developers. This helps them understand the benefits of the update. The docs/releases/Hotfix-Documentation-Best-Practices.md file provides more detailed guidance on writing effective hotfix notes.
Style Guide References
Footnotes
-
The style guide emphasizes that documentation should be useful. A changelog entry that only states a version bump without explaining its benefits is not as useful as it could be for developers trying to understand the changes. ↩
|
autosubmit label was removed for flutter/flutter/178935, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
justinmc
left a comment
There was a problem hiding this comment.
LGTM besides the analyzer failure.
DEPS
Outdated
| # Dart is: https://github.com/dart-lang/sdk/blob/main/DEPS | ||
| # You can use //tools/dart/create_updated_flutter_deps.py to produce | ||
| # updated revision list of existing dependencies. | ||
| # updated revision list of existing dependencies. You will need to |
There was a problem hiding this comment.
Looks like there is a trailing space here and that's why it's failing!
|
autosubmit label was removed for flutter/flutter/178935, because Pull request flutter/flutter/178935 is not in a mergeable state. |
|
autosubmit label was removed for flutter/flutter/178935, because Pull request flutter/flutter/178935 is not in a mergeable state. |
flutter/flutter@3f553f6...7b98d50 2025-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix for win32 embedder failing to send all alt key downs to the flutter app (#179097)" (flutter/flutter#179136) 2025-11-26 matt.kosarek@canonical.com Fix for win32 embedder failing to send all alt key downs to the flutter app (flutter/flutter#179097) 2025-11-26 katelovett@google.com Modernize framework lints (flutter/flutter#179089) 2025-11-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add framework-side hitTestBehavior support to Semantics (#178817)" (flutter/flutter#179100) 2025-11-25 zhongliu88889@gmail.com Add framework-side hitTestBehavior support to Semantics (flutter/flutter#178817) 2025-11-25 engine-flutter-autoroll@skia.org Roll Packages from e019cf9 to cc3dca6 (1 revision) (flutter/flutter#179081) 2025-11-25 matt.kosarek@canonical.com Add tooltip windows to the windowing API alongside the window positioning logic (flutter/flutter#177404) 2025-11-25 matt.kosarek@canonical.com FlutterWindowsView::SendWindowMetrics now reliably sends the display_id (flutter/flutter#179053) 2025-11-25 31859944+LongCatIsLooong@users.noreply.github.com Remove semantics geometry shortcircuit (flutter/flutter#178680) 2025-11-25 bruno.leroux@gmail.com Add an assert message when OverlayEntry.remove is called twice (flutter/flutter#178163) 2025-11-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pOO9Jl9HTLsEmks6y... to nzuAxCJGeJbkZCTkr... (flutter/flutter#179066) 2025-11-25 okorohelijah@google.com Dynamically set MinimumOSVersion in App.framework (flutter/flutter#178253) 2025-11-25 engine-flutter-autoroll@skia.org Roll Skia from d83c30b090f4 to 925c311f4b37 (2 revisions) (flutter/flutter#179060) 2025-11-25 fluttergithubbot@gmail.com Marks Linux build_android_host_app_with_module_aar to be unflaky (flutter/flutter#174864) 2025-11-25 fluttergithubbot@gmail.com Marks Linux_mokey complex_layout__start_up to be unflaky (flutter/flutter#174865) 2025-11-25 vegorov@google.com Manual Dart SDK roll to 3.11.0-169.0.dev (flutter/flutter#179054) 2025-11-25 katelovett@google.com Bump Dart to 3.9 (flutter/flutter#179041) 2025-11-25 engine-flutter-autoroll@skia.org Roll Skia from e298c2f93ebf to d83c30b090f4 (2 revisions) (flutter/flutter#179058) 2025-11-24 30870216+gaaclarke@users.noreply.github.com updated licenses_cpp readme (flutter/flutter#178874) 2025-11-24 engine-flutter-autoroll@skia.org Roll Skia from 43d2020be565 to e298c2f93ebf (5 revisions) (flutter/flutter#179046) 2025-11-24 116356835+AbdeMohlbi@users.noreply.github.com Refactor `_isLabel` method in `stepper.dart` to use `any` for better readablity (flutter/flutter#178909) 2025-11-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 5 to 6 in the all-github-actions group (flutter/flutter#179049) 2025-11-24 38378650+hgraceb@users.noreply.github.com Disposes test restoration manager when accessed by bindings (flutter/flutter#176519) 2025-11-24 bkonyi@google.com [ Widget Preview ] Always generate scaffold under `$TMP` (flutter/flutter#179039) 2025-11-24 engine-flutter-autoroll@skia.org Roll Packages from e67b6be to e019cf9 (9 revisions) (flutter/flutter#179035) 2025-11-24 1063596+reidbaker@users.noreply.github.com Update CHANGELOG.md for Flutter 3.38.3 (flutter/flutter#178935) 2025-11-24 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary `String.valueOf` in `SettingsChannel.java` (flutter/flutter#178590) 2025-11-24 katelovett@google.com Roll pub manually, pick up flutter_lints in examples/api (flutter/flutter#179030) 2025-11-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 24cc9a740bd3 to afca43095efa (1 revision) (flutter/flutter#179019) 2025-11-24 zezohassam@gmail.com Pass EXCLUDED_ARCHS from Xcode project to xcodebuild for macOS builds (flutter/flutter#176948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Added release notes for Flutter version 3.38.3. and better instructions for updating dart version in deps.
Added release notes for Flutter version 3.38.3. and better instructions for updating dart version in deps.
Added release notes for Flutter version 3.38.3.
and better instructions for updating dart version in deps.