Disposes test restoration manager when accessed by bindings #176519

hgraceb · 2025-10-04T10:40:16Z

Details

The error caused by drag is due to the reference to ServicesBinding.instance.restorationManager in the ScrollableState.saveOffset method.

flutter/packages/flutter/lib/src/widgets/scrollable.dart

Lines 648 to 656 in 018897e

    
           @protected 
        
           @override 
        
           void saveOffset(double offset) { 
        
             assert(debugIsSerializableForRestoration(offset)); 
        
             _persistedScrollOffset.value = offset; 
        
             // [saveOffset] is called after a scrolling ends and it is usually not 
        
             // followed by a frame. Therefore, manually flush restoration data. 
        
             ServicesBinding.instance.restorationManager.flushData(); 
        
           }

The TestWidgetsFlutterBinding now only cleans up the restorationManager when reset is called. Therefore, we need to find an appropriate place to clean up the restorationManager.

flutter/packages/flutter_test/lib/src/binding.dart

Lines 239 to 263 in 018897e

    
             @override 
        
             TestRestorationManager get restorationManager { 
        
               _restorationManager ??= createRestorationManager(); 
        
               return _restorationManager!; 
        
             } 
        
             TestRestorationManager? _restorationManager; 
        
             /// Called by the test framework at the beginning of a widget test to 
        
             /// prepare the binding for the next test. 
        
             /// 
        
             /// If [registerTestTextInput] returns true when this method is called, 
        
             /// the [testTextInput] is configured to simulate the keyboard. 
        
             void reset() { 
        
               _restorationManager?.dispose(); 
        
               _restorationManager = null; 
        
               platformDispatcher.defaultRouteNameTestValue = '/'; 
        
               resetGestureBinding(); 
        
               testTextInput.reset(); 
        
               if (registerTestTextInput) { 
        
                 _testTextInput.register(); 
        
               } 
        
               CustomSemanticsAction.resetForTests(); // ignore: invalid_use_of_visible_for_testing_member 
        
               _enableFocusManagerLifecycleAwarenessIfSupported(); 
        
             }

flutter/packages/flutter_test/lib/src/widget_tester.dart

Lines 188 to 193 in 018897e

    
           try { 
        
             memento = await variant.setUp(value); 
        
             binding.reset(); // TODO(ianh): the binding should just do this itself in _runTest 
        
             maybeSetupLeakTrackingForTest(experimentalLeakTesting, combinedDescription); 
        
             await callback(tester); 
        
           } finally {

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

dkwingsmt

LGTM. Thank you!

dkwingsmt · 2025-10-10T05:56:06Z

packages/flutter_test/test/widget_tester_leaks_free_test.dart

+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
+
+void main() {
+  LeakTesting.enable(); // Enable leak testing and use default collectedLeaksReporter.


Do we really need this statement? Leak testing isn't enabled unless the LEAK_TRACKING flag is set, but this is done for a reason. All Flutter unit tests are currently configured with leak tracking in this way, and I don't see a reason why WidgetTester needs special treatment.

And if this is removed, shall we move this test to widget_tester_test.dart?

I tried removing this piece of code, and I also temporarily commented out this patch by 3dabca1, but all the tests passed. So it might still need to be explicitly enabled in the code? Or did I miss something?

I found two parts in the existing code that might be related. One is the section that reads the LEAK_TRACKING flag, but this is part of flutter, and there is no similar handling under flutter_test.

flutter/packages/flutter/test/flutter_test_config.dart

Lines 15 to 29 in 255b464

/// If true, leak tracking is enabled for all `testWidgets`.

///

/// By default it is false.

/// To enable the leak tracking, either pass the compilation flag

/// `--dart-define LEAK_TRACKING=true` or invoke `export LEAK_TRACKING=true`.

///

/// See documentation for [testWidgets] on how to except individual tests.

bool _isLeakTrackingEnabled() {

if (kIsWeb) {

return false;

}

// The values can be different, one is compile time, another is run time.

return const bool.fromEnvironment('LEAK_TRACKING') ||

(bool.tryParse(Platform.environment['LEAK_TRACKING'] ?? '') ?? false);

}

The other is the code that tests for memory leaks under flutter_test, but it uses a custom collectedLeaksReporter, which is also one of the reasons I created a new file to write the test code.

flutter/packages/flutter_test/test/widget_tester_leaks_test.dart

Lines 23 to 33 in 255b464

void main() {

LeakTesting.collectedLeaksReporter = _verifyLeaks;

LeakTesting.enable();

LeakTesting.settings = LeakTesting.settings

.withTrackedAll()

.withTracked(allNotDisposed: true, experimentalAllNotGCed: true)

.withIgnored(

createdByTestHelpers: true,

testHelperExceptions: <RegExp>[RegExp(RegExp.escape(memoryLeakTestsFilePath()))],

);

Yeah. I've tested locally and you're right. Let me ask around and see what's the best approach. Thank you for you detailed reply!

packages/flutter_test/test/widget_tester_leaks_free_test.dart

justinmc · 2025-10-14T22:28:20Z

packages/flutter_test/lib/src/binding.dart

+      // _restorationManager?.dispose();
+      // _restorationManager = null;


@hgraceb Looks like you accidentally pushed a commit that comments some things out?

@justinmc That was to verify the issue mentioned in #176519 (comment). I'm not sure if the results are completely consistent between local and CI. I have reverted it.

dkwingsmt · 2025-10-15T17:57:34Z

I've filed a PR #176992 that adds CI tasks to test leak tracking for flutter_test. Let's wait until that PR is decided.

victorsanni

The Google testing failure is caused by this failing test in go_router.

justinmc · 2025-10-21T22:20:15Z

@hgraceb Any thoughts on what should be done about the failing go_router test? Is that something that this PR could work around?

hgraceb · 2025-10-22T10:43:22Z

@victorsanni @justinmc @ValentinVignal

The modifications in the go_router PR at #7456 are preventing the current PR from being merged.

From my understanding, the changes in #7456 and my current modifications are equivalent; both aim to address the leakage issue with TestWidgetsFlutterBinding.restorationManager after enabling leak testing. However, the changes in #7456 seem more like a temporary patch.

I believe the changes in go_router should be reverted, and after merging the current PR, the effect would remain the same as before. However, if I submit a separate PR for go_router now, both tests will fail; they will only pass if changes are made on both sides simultaneously.

Does anyone have good suggestions on how to proceed?

ValentinVignal · 2025-10-22T12:36:53Z

Revert the unwanted changes in go_router + disable leak memory testing for those specific tests, for example using:

  testWidgets(
    'Date formatting test',
    (WidgetTester tester) async {},
    experimentalLeakTesting: LeakTesting.settings.withIgnored(
      classes: const ['TestRestorationManager'],
    ),
  );

and add a TODO to remove it when go_router's minimum flutter version includes this PR

Merge this PR
Remove the ignore part in go_router when the minimum version of flutter includes this fix.

experimentalLeakTesting: LeakTesting.settings.withIgnored(
      classes: const ['TestRestorationManager'],
    ),

What do you think of that?

hgraceb · 2025-10-22T13:21:52Z

@ValentinVignal This sounds great, I submitted a PR: flutter/packages#10276.

migrating test for flutter/flutter#176519 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

victorsanni · 2025-11-11T20:14:26Z

Rebasing to rerun google testing.

My understanding is with flutter/packages#10276 the go_router failures should be fixed?

hgraceb · 2025-11-13T12:58:49Z

My understanding is with flutter/packages#10276 the go_router failures should be fixed?

@victorsanni Yes, is it still the previous error, or is there a new error now?

victorsanni · 2025-11-14T18:50:49Z

Yes, is it still the previous error, or is there a new error now?

Same error

…lutter/flutter#176519)

flutter/flutter@3f553f6...7b98d50 2025-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix for win32 embedder failing to send all alt key downs to the flutter app (#179097)" (flutter/flutter#179136) 2025-11-26 matt.kosarek@canonical.com Fix for win32 embedder failing to send all alt key downs to the flutter app (flutter/flutter#179097) 2025-11-26 katelovett@google.com Modernize framework lints (flutter/flutter#179089) 2025-11-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add framework-side hitTestBehavior support to Semantics (#178817)" (flutter/flutter#179100) 2025-11-25 zhongliu88889@gmail.com Add framework-side hitTestBehavior support to Semantics (flutter/flutter#178817) 2025-11-25 engine-flutter-autoroll@skia.org Roll Packages from e019cf9 to cc3dca6 (1 revision) (flutter/flutter#179081) 2025-11-25 matt.kosarek@canonical.com Add tooltip windows to the windowing API alongside the window positioning logic (flutter/flutter#177404) 2025-11-25 matt.kosarek@canonical.com FlutterWindowsView::SendWindowMetrics now reliably sends the display_id (flutter/flutter#179053) 2025-11-25 31859944+LongCatIsLooong@users.noreply.github.com Remove semantics geometry shortcircuit (flutter/flutter#178680) 2025-11-25 bruno.leroux@gmail.com Add an assert message when OverlayEntry.remove is called twice (flutter/flutter#178163) 2025-11-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pOO9Jl9HTLsEmks6y... to nzuAxCJGeJbkZCTkr... (flutter/flutter#179066) 2025-11-25 okorohelijah@google.com Dynamically set MinimumOSVersion in App.framework (flutter/flutter#178253) 2025-11-25 engine-flutter-autoroll@skia.org Roll Skia from d83c30b090f4 to 925c311f4b37 (2 revisions) (flutter/flutter#179060) 2025-11-25 fluttergithubbot@gmail.com Marks Linux build_android_host_app_with_module_aar to be unflaky (flutter/flutter#174864) 2025-11-25 fluttergithubbot@gmail.com Marks Linux_mokey complex_layout__start_up to be unflaky (flutter/flutter#174865) 2025-11-25 vegorov@google.com Manual Dart SDK roll to 3.11.0-169.0.dev (flutter/flutter#179054) 2025-11-25 katelovett@google.com Bump Dart to 3.9 (flutter/flutter#179041) 2025-11-25 engine-flutter-autoroll@skia.org Roll Skia from e298c2f93ebf to d83c30b090f4 (2 revisions) (flutter/flutter#179058) 2025-11-24 30870216+gaaclarke@users.noreply.github.com updated licenses_cpp readme (flutter/flutter#178874) 2025-11-24 engine-flutter-autoroll@skia.org Roll Skia from 43d2020be565 to e298c2f93ebf (5 revisions) (flutter/flutter#179046) 2025-11-24 116356835+AbdeMohlbi@users.noreply.github.com Refactor `_isLabel` method in `stepper.dart` to use `any` for better readablity (flutter/flutter#178909) 2025-11-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 5 to 6 in the all-github-actions group (flutter/flutter#179049) 2025-11-24 38378650+hgraceb@users.noreply.github.com Disposes test restoration manager when accessed by bindings (flutter/flutter#176519) 2025-11-24 bkonyi@google.com [ Widget Preview ] Always generate scaffold under `$TMP` (flutter/flutter#179039) 2025-11-24 engine-flutter-autoroll@skia.org Roll Packages from e67b6be to e019cf9 (9 revisions) (flutter/flutter#179035) 2025-11-24 1063596+reidbaker@users.noreply.github.com Update CHANGELOG.md for Flutter 3.38.3 (flutter/flutter#178935) 2025-11-24 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary `String.valueOf` in `SettingsChannel.java‎` (flutter/flutter#178590) 2025-11-24 katelovett@google.com Roll pub manually, pick up flutter_lints in examples/api (flutter/flutter#179030) 2025-11-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 24cc9a740bd3 to afca43095efa (1 revision) (flutter/flutter#179019) 2025-11-24 zezohassam@gmail.com Pass EXCLUDED_ARCHS from Xcode project to xcodebuild for macOS builds (flutter/flutter#176948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…176519) Fixes flutter#169119 ## Details The error caused by drag is due to the reference to `ServicesBinding.instance.restorationManager` in the `ScrollableState.saveOffset` method. https://github.com/flutter/flutter/blob/018897e3f12c5783fb025bcbd92515a69d4d5c32/packages/flutter/lib/src/widgets/scrollable.dart#L648-L656 The TestWidgetsFlutterBinding now only cleans up the `restorationManager` when `reset` is called. Therefore, we need to find an appropriate place to clean up the `restorationManager`. https://github.com/flutter/flutter/blob/018897e3f12c5783fb025bcbd92515a69d4d5c32/packages/flutter_test/lib/src/binding.dart#L239-L263 https://github.com/flutter/flutter/blob/018897e3f12c5783fb025bcbd92515a69d4d5c32/packages/flutter_test/lib/src/widget_tester.dart#L188-L193 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com>

This PR adds a new subshard that runs leak tracking tests on flutter/misc. This is used to address a problem faced by PR #176519, which fixes a leak in `WidgetTester` but is unable to write a unit test. I'm not certain this is the best approach so I'm open to other suggestions. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…art` (#180600) When #176519 was authored, there were no CI shards that run `flutter_test` with leak tests, and therefore the test had to be placed in a separate file. Now that #176992 has added misc leak tracking, the test case can be placed in the same file as other tests for `WidgetTester`. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Oct 4, 2025

hgraceb marked this pull request as ready for review October 4, 2025 14:56

justinmc requested a review from victorsanni October 7, 2025 22:12

dkwingsmt self-requested a review October 7, 2025 22:14

dkwingsmt approved these changes Oct 10, 2025

View reviewed changes

dkwingsmt reviewed Oct 10, 2025

View reviewed changes

hgraceb force-pushed the leak branch from 031d30a to 3dabca1 Compare October 11, 2025 12:56

dkwingsmt mentioned this pull request Oct 14, 2025

Enable misc leak tracking #176992

Merged

9 tasks

justinmc reviewed Oct 14, 2025

View reviewed changes

hgraceb force-pushed the leak branch from 885b9d6 to 36a3bc2 Compare October 15, 2025 11:18

victorsanni approved these changes Oct 17, 2025

View reviewed changes

victorsanni reviewed Oct 20, 2025

View reviewed changes

hgraceb mentioned this pull request Oct 22, 2025

[go_router] Migrates test for leak testing flutter/packages#10276

Merged

11 tasks

Piinks added this to Google Testing Queue Nov 11, 2025

hgraceb added 6 commits November 15, 2025 21:58

Disposes test restoration manager when accessed by bindings

9c6c0a4

Add copyright

d293a46

Revert

869d793

Disposes test restoration manager when accessed by bindings

3079458

Disposes test restoration manager when accessed by bindings

c53e460

Disposes test restoration manager when accessed by bindings

75cbea0

victorsanni moved this from Todo to In Progress in Google Testing Queue Nov 22, 2025

Merge branch 'master' into leak

155c4d6

victorsanni moved this from In Progress to Done in Google Testing Queue Nov 24, 2025

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 24, 2025

auto-submit bot added this pull request to the merge queue Nov 24, 2025

Merged via the queue into flutter:master with commit 35d9502 Nov 24, 2025
69 of 70 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 24, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

f6fc167

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 68115a705fe2 (22 revisions) flutter/packages#10512

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

59db1e7

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 2778dfd2cb7b (23 revisions) flutter/packages#10513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

e13720c

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 084deda0ba3f (24 revisions) flutter/packages#10514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

71cc410

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 882c29a1947c (25 revisions) flutter/packages#10515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

b52e394

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 882c29a1947c (25 revisions) flutter/packages#10518

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

37687e7

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 8f3f89f75e8c (26 revisions) flutter/packages#10519

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

6a60a67

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 26, 2025

Roll Flutter from 3f553f6779cb to fde117b7b144 (29 revisions) flutter/packages#10522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2025

35d9502 Disposes test restoration manager when accessed by bindings (f…

6b165d4

…lutter/flutter#176519)

engine-flutter-autoroll mentioned this pull request Nov 26, 2025

Roll Flutter from 3f553f6779cb to 7b98d50631e5 (30 revisions) flutter/packages#10523

Merged

dkwingsmt mentioned this pull request Jan 6, 2026

Merge widget_tester_leaks_free_test.dart into widget_tester_test.dart #180600

Merged

9 tasks

	@protected
	@override
	void saveOffset(double offset) {
	assert(debugIsSerializableForRestoration(offset));
	_persistedScrollOffset.value = offset;
	// [saveOffset] is called after a scrolling ends and it is usually not
	// followed by a frame. Therefore, manually flush restoration data.
	ServicesBinding.instance.restorationManager.flushData();
	}

	@override
	TestRestorationManager get restorationManager {
	_restorationManager ??= createRestorationManager();
	return _restorationManager!;
	}

	TestRestorationManager? _restorationManager;

	/// Called by the test framework at the beginning of a widget test to
	/// prepare the binding for the next test.
	///
	/// If [registerTestTextInput] returns true when this method is called,
	/// the [testTextInput] is configured to simulate the keyboard.
	void reset() {
	_restorationManager?.dispose();
	_restorationManager = null;
	platformDispatcher.defaultRouteNameTestValue = '/';
	resetGestureBinding();
	testTextInput.reset();
	if (registerTestTextInput) {
	_testTextInput.register();
	}
	CustomSemanticsAction.resetForTests(); // ignore: invalid_use_of_visible_for_testing_member
	_enableFocusManagerLifecycleAwarenessIfSupported();
	}

	try {
	memento = await variant.setUp(value);
	binding.reset(); // TODO(ianh): the binding should just do this itself in _runTest
	maybeSetupLeakTrackingForTest(experimentalLeakTesting, combinedDescription);
	await callback(tester);
	} finally {

	/// If true, leak tracking is enabled for all `testWidgets`.
	///
	/// By default it is false.
	/// To enable the leak tracking, either pass the compilation flag
	/// `--dart-define LEAK_TRACKING=true` or invoke `export LEAK_TRACKING=true`.
	///
	/// See documentation for [testWidgets] on how to except individual tests.
	bool _isLeakTrackingEnabled() {
	if (kIsWeb) {
	return false;
	}
	// The values can be different, one is compile time, another is run time.
	return const bool.fromEnvironment('LEAK_TRACKING') \|\|
	(bool.tryParse(Platform.environment['LEAK_TRACKING'] ?? '') ?? false);
	}

	void main() {
	LeakTesting.collectedLeaksReporter = _verifyLeaks;
	LeakTesting.enable();

	LeakTesting.settings = LeakTesting.settings
	.withTrackedAll()
	.withTracked(allNotDisposed: true, experimentalAllNotGCed: true)
	.withIgnored(
	createdByTestHelpers: true,
	testHelperExceptions: <RegExp>[RegExp(RegExp.escape(memoryLeakTestsFilePath()))],
	);

		// _restorationManager?.dispose();
		// _restorationManager = null;

Disposes test restoration manager when accessed by bindings #176519

Disposes test restoration manager when accessed by bindings #176519

Uh oh!

Conversation

hgraceb commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Pre-launch Checklist

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

hgraceb Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

hgraceb Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented Oct 15, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Oct 21, 2025

Uh oh!

hgraceb commented Oct 22, 2025

Uh oh!

ValentinVignal commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hgraceb commented Oct 22, 2025

Uh oh!

victorsanni commented Nov 11, 2025

Uh oh!

hgraceb commented Nov 13, 2025

Uh oh!

victorsanni commented Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hgraceb commented Oct 4, 2025 •

edited

Loading

ValentinVignal commented Oct 22, 2025 •

edited

Loading