Skip to content

[fuchsia][sysmem2] switch to sysmem2 tokens #166120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dustingreen merged 1 commit into from
Mar 29, 2025
Merged

[fuchsia][sysmem2] switch to sysmem2 tokens #166120

dustingreen merged 1 commit into from
Mar 29, 2025

Conversation

@dustingreen
Copy link
Contributor

@dustingreen dustingreen commented Mar 28, 2025 •
edited
Loading

Now that fuchsia protocols can convey sysmem2 tokens, avoid token conversions.

fixes #166121

cl/741415017 per go/flutter-fuchsia-pr-policy

Pre-launch Checklist

  • [y] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [y] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [y] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [y] I signed the [CLA].
  • [y] I listed at least one issue that this PR fixes in the description above.
  • [na] I updated/added relevant documentation (doc comments with ///).
  • [tbd] I added new tests to check the change I am making, or this PR is [test-exempt].
    • identical functionalilty; covered by existing tests
  • [na] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • [y] All existing and new tests are passing.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-fuchsia Fuchsia code specifically labels Mar 28, 2025
@dustingreen dustingreen requested a review from jrwang March 28, 2025 07:32
jrwang
jrwang approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustingreen
[fuchsia][sysmem2] switch to sysmem2 tokens
c8e695f 
Now that fuchsia protocols can convey sysmem2 tokens, avoid token
conversions.
@dustingreen dustingreen force-pushed the rm_token_conversion branch from da14180 to c8e695f Compare March 29, 2025 04:20
@dustingreen dustingreen enabled auto-merge March 29, 2025 04:23
@dustingreen dustingreen added this pull request to the merge queue Mar 29, 2025
Merged via the queue into flutter:master with commit 13b7484 Mar 29, 2025
171 of 172 checks passed
@dustingreen dustingreen deleted the rm_token_conversion branch March 29, 2025 06:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
81ada4c 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
447ca5c 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
164f540 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
24e1d19 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
3eb1516 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
d477939 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
795704d 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
f8cfd83 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
373cab6 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
2033adf 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
59899db 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
eaa9155 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
0bda9ad 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
233f64f 
…166120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
5dd5c25 
…166120)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (#8960)
84ef201 
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions)…
c5e236f 
… (#8960)

Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
b331e0b 
…166120)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
6c4a034 
…166120)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
13b7484 [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#…
c3dfa2f 
…166120)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter#…
166c443 
…8960)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@dustingreen
[fuchsia][sysmem2] switch to sysmem2 tokens (flutter#166120)
f63891d 
Now that fuchsia protocols can convey sysmem2 tokens, avoid token
conversions.

fixes flutter#166121

[cl/741415017](http://cl/741415017) per
[go/flutter-fuchsia-pr-policy](http://go/flutter-fuchsia-pr-policy)

## Pre-launch Checklist

- [y] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [y] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [y] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [y] I signed the [CLA].
- [y] I listed at least one issue that this PR fixes in the description
above.
- [na] I updated/added relevant documentation (doc comments with `///`).
- [tbd] I added new tests to check the change I am making, or this PR is
[test-exempt].
  - identical functionalilty; covered by existing tests
- [na] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [y] All existing and new tests are passing.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter#…
0dc8f54 
…8960)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@dustingreen @romanejaquez
[fuchsia][sysmem2] switch to sysmem2 tokens (flutter#166120)
fc7e0a3 
Now that fuchsia protocols can convey sysmem2 tokens, avoid token
conversions.

fixes flutter#166121

[cl/741415017](http://cl/741415017) per
[go/flutter-fuchsia-pr-policy](http://go/flutter-fuchsia-pr-policy)

## Pre-launch Checklist

- [y] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [y] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [y] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [y] I signed the [CLA].
- [y] I listed at least one issue that this PR fixes in the description
above.
- [na] I updated/added relevant documentation (doc comments with `///`).
- [tbd] I added new tests to check the change I am making, or this PR is
[test-exempt].
  - identical functionalilty; covered by existing tests
- [na] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [y] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrwang jrwang jrwang approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-fuchsia Fuchsia code specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fuchsia sysmem(1) to sysmem2 migration - can remove some token conversions

2 participants

@dustingreen @jrwang