Skip to content

[Impeller] allow newer powervr gpu to use Vulkan. #165520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 9 commits into from
Mar 28, 2025
Merged

[Impeller] allow newer powervr gpu to use Vulkan. #165520

auto-submit merged 9 commits into from
Mar 28, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 19, 2025

Not to be landed until #165497 lands.

We don't both to parse the model number until CXT and DXT as all prior models shouldn't be used.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 19, 2025
@jonahwilliams jonahwilliams requested a review from gaaclarke March 19, 2025 23:35
gaaclarke
gaaclarke approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a necessary comment on the order of the enum.

engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.h
Comment on lines 111 to 126
enum class PowerVRGPU {
kUnknown,
// Not good.
// kRogue,
// Vulkan may work, but not tested.
// kAXE,
// kAXM,
// kAXT,
// kBXE,
// kBXM,
// kBXS,
// kBXT,
// First good vulkan drivers.
kCXT,
kDXT,
};
Copy link
Member

@gaaclarke gaaclarke Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document the order of these since we depend on the order in the code? (edit: as a docstring)

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are listed in the order they were released. Or do you mean, what the order is?

Copy link
Member

@gaaclarke gaaclarke Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, i figured they are the order they are released. That's what I meant.

/// The list of PowerVRGPU's listed chronologically.

So wait, does that mean when a new phone comes out after DXT it's going to be classified as kUnknown and opt out of vulkan?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

Copy link
Member

@gaaclarke gaaclarke Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case something like this:

/// The list of PowerVRGPU's listed chronologically.
/// Novel devices are classified as the oldest devices intentionally.

Seems like we'd want novel devices to opt into vulkan though.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could invert these checks then?

Copy link
Member

@gaaclarke gaaclarke Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That only works though if we start definitively classifying all the old devices. Do we have a way to see what the string says for those devices, like for the Rogue? I think that's possible by looking at gpuinfo.org.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically if string contains rogue, then its bad

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me think about this for a bit

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 28, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #165520 at sha ad9231f

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 28, 2025
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 28, 2025
Merged via the queue into flutter:master with commit 5e18e59 Mar 28, 2025
172 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
fc5f7cf 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
b4c9de1 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
442745b 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
189aec3 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
406b8c3 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
33b4ca4 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
95f6d2b 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
ceae764 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
ab89795 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
df50bd3 
…utter#165520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
426f1fe 
…utter#165520)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
969acce 
…utter#165520)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
d6c78dc 
…utter#165520)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
eb3250c 
…utter#165520)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
f794748 
…utter#165520)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (#8960)
84ef201 
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions)…
c5e236f 
… (#8960)

Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
e007a0f 
…utter#165520)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
f525c00 
…utter#165520)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5e18e59 [Impeller] allow newer powervr gpu to use Vulkan. (flutter/fl…
f14aa13 
…utter#165520)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter#…
166c443 
…8960)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
[Impeller] allow newer powervr gpu to use Vulkan. (flutter#165520)
2d5f73f 
Not to be landed until flutter#165497
lands.

We don't both to parse the model number until CXT and DXT as all prior
models shouldn't be used.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter#…
0dc8f54 
…8960)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@1d954f4...05b5e79

2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917)
2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] allow newer powervr gpu to use Vulkan. (flutter#165520)
6da479f 
Not to be landed until flutter#165497
lands.

We don't both to parse the model number until CXT and DXT as all prior
models shouldn't be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke