[ios][pv]fully revert the UIScreen.main deprecated API change #166080

hellohuanlin · 2025-03-27T17:53:49Z

This PR fully reverts #162785

Due to crash from an internal customer

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

auto-submit · 2025-03-27T21:23:21Z

autosubmit label was removed for flutter/flutter/166080, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tState call (flutter#166024)" This reverts commit 1eae5e7.

…r#165525)" This reverts commit 4cb18b3.

…)" This reverts commit 3d2ab87.

auto-submit · 2025-03-28T00:29:14Z

autosubmit label was removed for flutter/flutter/166080, because - The status or check suite Windows tool_integration_tests_8_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Windows tool_integration_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_4_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows plugin_test_windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_widgets_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_libraries_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_1_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_android_emu android_engine_opengles_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux android_preview_tool_integration_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_integration_tests_6_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_integration_tests_4_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux run_debug_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_android_host_app_with_module_aar has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux gradle_plugin_fat_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

…flutter/flutter#166080)

jmagman · 2025-03-28T16:13:43Z

cc @dkyurtov

…flutter/flutter#166080)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@1d954f4...05b5e79 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185) 2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181) 2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180) 2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998) 2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744) 2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149) 2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162) 2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161) 2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034) 2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035) 2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924) 2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681) 2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520) 2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324) 2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091) 2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144) 2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136) 2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938) 2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409) 2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709) 2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627) 2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080) 2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111) 2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031) 2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025) 2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942) 2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972) 2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103) 2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819) 2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346) 2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005) 2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395) 2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096) 2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060) 2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940) 2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917) 2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059) 2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046) 2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299) ...

… (#8960) Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@1d954f4...05b5e79 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185) 2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181) 2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180) 2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998) 2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744) 2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149) 2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162) 2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161) 2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034) 2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035) 2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924) 2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681) 2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520) 2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324) 2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091) 2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144) 2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136) 2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938) 2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409) 2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709) 2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627) 2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080) 2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111) 2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031) 2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025) 2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942) 2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972) 2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103) 2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819) 2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346) 2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005) 2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395) 2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096) 2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060) 2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940) 2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917) 2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059) 2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046) 2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299) ...

…flutter/flutter#166080)

…8960) Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@1d954f4...05b5e79 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185) 2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181) 2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180) 2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998) 2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744) 2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149) 2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162) 2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161) 2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034) 2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035) 2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924) 2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681) 2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520) 2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324) 2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091) 2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144) 2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136) 2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938) 2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409) 2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709) 2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627) 2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080) 2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111) 2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031) 2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025) 2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942) 2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972) 2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103) 2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819) 2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346) 2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005) 2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395) 2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096) 2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060) 2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940) 2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917) 2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059) 2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046) 2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299) ...

…r#166080) This PR fully reverts flutter#162785 Due to crash from an internal customer Fixes flutter#165648 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Jenn Magder <magder@google.com>

…8960) Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@1d954f4...05b5e79 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185) 2025-03-29 dustingreen@google.com [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120) 2025-03-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181) 2025-03-29 jonahwilliams@google.com move around shaders in vertices uber 1/2 (flutter/flutter#166180) 2025-03-29 jonahwilliams@google.com [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998) 2025-03-28 sokolovskyi.konstantin@gmail.com Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744) 2025-03-28 30870216+gaaclarke@users.noreply.github.com Started clamping scaled antialias lines size (flutter/flutter#166149) 2025-03-28 jason-simmons@users.noreply.github.com Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162) 2025-03-28 58190796+MitchellGoodwin@users.noreply.github.com Remove bringup flag for customer tests (flutter/flutter#166161) 2025-03-28 737941+loic-sharma@users.noreply.github.com Add the ios-reviewers review team (flutter/flutter#166034) 2025-03-28 30870216+gaaclarke@users.noreply.github.com [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035) 2025-03-28 21270878+elliette@users.noreply.github.com [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924) 2025-03-28 31859944+LongCatIsLooong@users.noreply.github.com Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681) 2025-03-28 jonahwilliams@google.com [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520) 2025-03-28 58529443+srujzs@users.noreply.github.com [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324) 2025-03-28 bkonyi@google.com [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091) 2025-03-28 zanderso@users.noreply.github.com Mark Linux coverage as bringup (flutter/flutter#166144) 2025-03-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136) 2025-03-28 jonahwilliams@google.com [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938) 2025-03-28 byoungchan.lee@gmx.com [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409) 2025-03-28 andrewrkolos@gmail.com Delete some verbose vm service logging (flutter/flutter#162709) 2025-03-28 andrewrkolos@gmail.com Get analytics welcome message under test (flutter/flutter#162627) 2025-03-28 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080) 2025-03-28 engine-flutter-autoroll@skia.org Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111) 2025-03-28 jonahwilliams@google.com [CI] remove check for exact golden files. (flutter/flutter#166031) 2025-03-28 robert.ancell@canonical.com Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025) 2025-03-27 jonahwilliams@google.com [android] only release background image readers on Android 14. (flutter/flutter#165942) 2025-03-27 34465683+rkishan516@users.noreply.github.com Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972) 2025-03-27 58190796+MitchellGoodwin@users.noreply.github.com Mark Linux customer tests as flaky (flutter/flutter#166103) 2025-03-27 1063596+reidbaker@users.noreply.github.com Move app link settings task configuration to kotlin (flutter/flutter#165819) 2025-03-27 15619084+vashworth@users.noreply.github.com Make iOS Flutter framework extension-safe (flutter/flutter#165346) 2025-03-27 bkonyi@google.com [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005) 2025-03-27 66560136+Mastermind-sap@users.noreply.github.com Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395) 2025-03-27 92773903+yakagami@users.noreply.github.com add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096) 2025-03-27 bkonyi@google.com Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060) 2025-03-27 jason-simmons@users.noreply.github.com [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940) 2025-03-27 30870216+gaaclarke@users.noreply.github.com Scale aa lines (flutter/flutter#165917) 2025-03-27 bkonyi@google.com Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059) 2025-03-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055) 2025-03-27 engine-flutter-autoroll@skia.org Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046) 2025-03-27 danny@tuppeny.com [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299) ...

…r#166080) This PR fully reverts flutter#162785 Due to crash from an internal customer Fixes flutter#165648 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Jenn Magder <magder@google.com>

github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Mar 27, 2025

hellohuanlin changed the title ~~Pv regression on main scale full revert~~ [ios][pv]fully revert the UIScreen.main deprecated API change Mar 27, 2025

hellohuanlin requested review from cbracken and jmagman March 27, 2025 17:54

hellohuanlin mentioned this pull request Mar 27, 2025

[DO NOT LAND][LAST RESORT] [ios][pv] regression on screen scale revert to deprecated api #166036

Closed

9 tasks

jmagman approved these changes Mar 27, 2025

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025

hellohuanlin added 6 commits March 27, 2025 17:26

Revert "[ios][pv]check UIScreen to be nil in platform view overlay se…

26afc3c

…tState call (flutter#166024)" This reverts commit 1eae5e7.

Revert "[ios][pv]fix platform view crash due to screenScale=0 (flutte…

6140e7f

…r#165525)" This reverts commit 4cb18b3.

Revert "replace deprecated [UIScreen mainScreen] in iOS (flutter#162785…

c003171

…)" This reverts commit 3d2ab87.

format

3b78884

missing line

76605cf

missing line

52c25f3

hellohuanlin force-pushed the pv_regression_on_main_scale_full_revert branch from d23d97c to 52c25f3 Compare March 28, 2025 00:26

hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025

Merge branch 'master' into pv_regression_on_main_scale_full_revert

6c154a8

hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025

auto-submit bot added this pull request to the merge queue Mar 28, 2025

Merged via the queue into flutter:master with commit cbcdd7d Mar 28, 2025
171 of 172 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from b16430b2fd57 to 228a01170724 (317 revisions) flutter/packages#8925

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

9585709

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 30, 2025

Roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions) flutter/packages#8938

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

c6ca5a3

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Flutter from 1d954f4e96bd to 26ad92105da6 (229 revisions) flutter/packages#8959

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

815e19b

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions) flutter/packages#8960

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

e733ee7

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Flutter from 1d954f4e96bd to 9870afdc0cde (230 revisions) flutter/packages#8961

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

b52961c

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Flutter from 1d954f4e96bd to edf0322cf0bf (231 revisions) flutter/packages#8962

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

4dee1d0

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Flutter from 1d954f4e96bd to 1937cae5a947 (232 revisions) flutter/packages#8963

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

77526df

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Flutter from 1d954f4e96bd to 290a85e7f247 (233 revisions) flutter/packages#8965

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

2d42f83

…flutter/flutter#166080)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Flutter from 1d954f4e96bd to 53d93da57ae8 (236 revisions) flutter/packages#8966

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

9a82847

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

b7b4324

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

19d4d7a

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

53f0f34

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

a40a9b2

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

b586d7e

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

5a07130

…flutter/flutter#166080)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

cbcdd7d [ios][pv]fully revert the UIScreen.main deprecated API change (…

5af13b1

…flutter/flutter#166080)

hellohuanlin mentioned this pull request Jul 22, 2025

Scaling Issue with Native UiKitView on External Displays with Different Scale Factors #162184

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ios][pv]fully revert the UIScreen.main deprecated API change #166080

[ios][pv]fully revert the UIScreen.main deprecated API change #166080

Uh oh!

hellohuanlin commented Mar 27, 2025 •

edited by jmagman

Loading

Uh oh!

auto-submit bot commented Mar 27, 2025

Uh oh!

auto-submit bot commented Mar 28, 2025

Uh oh!

Uh oh!

jmagman commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[ios][pv]fully revert the UIScreen.main deprecated API change #166080

[ios][pv]fully revert the UIScreen.main deprecated API change #166080

Uh oh!

Conversation

hellohuanlin commented Mar 27, 2025 • edited by jmagman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

auto-submit bot commented Mar 27, 2025

Uh oh!

auto-submit bot commented Mar 28, 2025

Uh oh!

Uh oh!

jmagman commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hellohuanlin commented Mar 27, 2025 •

edited by jmagman

Loading